-
Notifications
You must be signed in to change notification settings - Fork 149
Replace connect with useSelector() and useDispatch() 3/5 #2316 #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2341 +/- ##
==========================================
+ Coverage 94.40% 94.42% +0.01%
==========================================
Files 1167 1168 +1
Lines 24957 24985 +28
Branches 5303 5304 +1
==========================================
+ Hits 23561 23591 +30
+ Misses 1329 1327 -2
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
For reviewers, please don't merge this until we've merged #2343 and rebased this on top of it. I suggest holding off on review until then as well.
const intl = useIntl(); | ||
const { editorRef, refReady, setEditorRef } = prepareEditorRef(); | ||
|
||
// Select state values using useSelector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove comment line.
@ahtesham-quraish Could you please take another look at this PR, and rebase it etc.? I'd appreciate if you can help get all your PRs green and ready for review, and address all outstanding comments before opening any more new PRs. I'll try to help with your coverage questions where I can, but I'm a little behind in my reviews at the moment. Thanks! |
Description
#2316.
Supporting information
Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for manually testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts
,.tsx
).propTypes
,defaultProps
, andinjectIntl
patterns are not used in any new or modified code.src/testUtils.tsx
(specificallyinitializeMocks
)apiHooks.ts
in this repo for examples.messages.ts
files have adescription
for translators to use.../
. To import from parent folders, use@src
, e.g.import { initializeMocks } from '@src/testUtils';
instead offrom '../../../../testUtils'