Skip to content

fix: Bug: Date picker controls cause MFE error on Safari #2343 #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Aug 5, 2025

Description

Bug: #2323

Supporting information

Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (8326257) to head (7bac405).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2352      +/-   ##
==========================================
- Coverage   94.40%   94.17%   -0.23%     
==========================================
  Files        1167     1169       +2     
  Lines       24957    25102     +145     
  Branches     5303     5490     +187     
==========================================
+ Hits        23561    23641      +80     
- Misses       1329     1386      +57     
- Partials       67       75       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/#2323 branch 3 times, most recently from 7ad0fea to 26a5feb Compare August 6, 2025 09:22
@ahtesham-quraish
Copy link
Contributor Author

@bradenmacdonald I’ve upgraded react-datepicker to version 7 (instead of 8) because the import issue with react-datepicker/dist/react-datepicker.css made it difficult to generate a local build with v8, even though that import is still documented. Version 7 works fine, so I’ve opted to use that for now and its working fine on safari as well.

Also, there are some lines marked as uncovered in the Codecov report that I haven’t modified. We should decide how to proceed with those. If you review the coverage report, you’ll notice that the uncovered lines were not part of my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant