-
Notifications
You must be signed in to change notification settings - Fork 149
Override upload file max size in mb #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Override upload file max size in mb #2370
Conversation
correction of comment regarding UPLOAD_FILE_MAX_SIZE value
create an override for the maxFileSize
alignment with import requirement "avoid using `../`. To import from parent folders, use `@src`, e.g. `import { initializeMocks } from '@src/testUtils';`"
Thanks for the pull request, @MuPp3t33r! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
For attention to @bradenmacdonald to review if this PR meets requirements.
Description
This update makes the following changes:
constants.js
:FilePage.jsx
:maxFileSize
value and instead import it from constants.jsModalDropzone.jsx
:UPLOAD_FILE_MAX_SIZE
constants that were defined and replaced with a call to the new function inconstants.js
TextbookForm.jsx
:UPLOAD_FILE_MAX_SIZE
constants that were defined and replaced with a call to the new function inconstants.js
Imports from constants now use the updated new format
'@src/constants'
instead of the old'../../constants'
Supporting information
this is an improvement to my previous attempt before i really knew what i was doing, now I only know a little bit of what I'm doing :)
Testing instructions
Note that this must be done in MFE_CONFIG and in the CaddyFile to allow Caddy to process your larger requests
Here is a sample plugin allowing user to provide one input for the value and it applies in both locations
tutor plugins enable override_max_asset_upload_size
tutor local stop && tutor local start -d
Now, under the following menus:
You will find that you can upload files up to whatever maximum defined in the
override_max_asset_upload_size
plugin