testing: Using Paragon CSS External Hosting (JavaScript-based configuration) by PKulkoRaccoonGang · Pull Request #707 · openedx/frontend-app-discussions

PKulkoRaccoonGang · 2024-05-27T16:42:02Z

Description

The JavaScript-based configuration approach allows the user to add Paragon CSS from external hosting.

module.exports = {
  PARAGON_THEME_URLS: {
    core: {
      urls: {
        default: 'https://cdn.jsdelivr.net/npm/@openedx/paragon@alpha/dist/core.min.css',
      },
    },
    defaults: {
      light: 'light',
      dark: 'dark',
    },
    variants: {
      light: {
        urls: {
          default: 'https://cdn.jsdelivr.net/npm/@openedx/paragon@alpha/dist/light.min.css',
        },
      },
      dark: {
        urls: {
          default: 'https://cdn.jsdelivr.net/npm/@edx/brand-edx.org@alpha/dist/light.min.css',
        },
      },
    },
  },
};

Info

Related PRs

openedx-webhooks · 2024-05-27T16:42:06Z

Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

open-craft-grove · 2024-05-29T14:30:58Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-07T15:44:58Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

codecov · 2024-06-26T08:17:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (422fbf6) to head (8720ea3).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         160      160           
  Lines        3329     3329           
  Branches      888      898   +10     
=======================================
  Hits         3092     3092           
+ Misses        219      218    -1     
- Partials       18       19    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

open-craft-grove · 2024-06-26T08:46:07Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-26T12:09:21Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-26T13:11:41Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-26T21:34:49Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-26T21:57:46Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-29T19:27:34Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-29T19:50:13Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-29T20:14:01Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-29T20:32:44Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-29T21:52:30Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-30T09:53:51Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-30T10:50:38Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-30T12:12:45Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-30T16:57:50Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-30T17:43:09Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

ihor-romaniuk · 2024-07-02T06:35:34Z

env.config.js

@@ -0,0 +1,25 @@
+module.exports = {


It seems this should be a temporary change and should be removed in the final implementation.

And I am not sure about merging it to the master branch directly. Probably, we should use some separate development brunch for pre-stage tasing and further releasing.

ihor-romaniuk · 2024-07-02T06:36:48Z

package.json

  ],
  "scripts": {
-    "build": "fedx-scripts webpack",
+    "build": "sh run-build-for-gh-deps.sh",


Also, these seem to be temporary changes and should be reverted at release.

open-craft-grove · 2024-07-02T16:39:38Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-07-02T18:53:46Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-07-03T10:23:21Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-07-03T11:38:45Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-07-03T12:38:41Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-07-03T13:30:05Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

refactor: code refactoring feat: necessary dependencies added refactor: corrected lint refactor: corrected sh refactor: added logs refactor: added temp frontend-platform dist refactor: updated run-build-for-gh-deps.sh refactor: corrected run-build-for-gh-deps.sh refactor: fixing the problem refactor: changed run build command feat: added header refactor: added dark theme and footer refactor: code refactoring refactor: code refactoring fix: fixed CommentsView button feat: added brand import feat: removed brand

openedx-webhooks · 2024-07-03T17:21:58Z

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 27, 2024

PKulkoRaccoonGang marked this pull request as draft May 27, 2024 16:42

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from e7bf503 to 740463f Compare May 28, 2024 08:54

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels May 28, 2024

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jun 26, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch 2 times, most recently from 54201dc to 40de617 Compare June 26, 2024 11:36

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from 40de617 to 67ae425 Compare June 26, 2024 12:14

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jun 26, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from 24e4bfc to e02ae37 Compare June 26, 2024 21:03

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jun 26, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from e02ae37 to 0445d5c Compare June 26, 2024 21:36

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jun 26, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from 86433c7 to ca58f58 Compare June 29, 2024 19:38

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jun 29, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from ca58f58 to 1e3054a Compare June 29, 2024 19:54

PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jun 29, 2024

PKulkoRaccoonGang force-pushed the Peter_Kulko/implementation-of-design-tokens branch from 1e3054a to 88f7c51 Compare June 29, 2024 20:47

This was referenced Jun 30, 2024

feat: MFE runtime configuration API #724

Closed

feat: Using locally installed Paragon CSS #723

Closed

ihor-romaniuk reviewed Jul 2, 2024

View reviewed changes

This was referenced Jul 2, 2024

Support 2u teams through deployment of first upgraded mfe openedx/paragon#3071

Closed

Update openedx/frontend-app-discussions to use the new combination of paragon+platform+build openedx/paragon#3069

Open

Conversation

PKulkoRaccoonGang commented May 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Info

Related PRs

Uh oh!

openedx-webhooks commented May 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

open-craft-grove commented May 29, 2024

Uh oh!

open-craft-grove commented Jun 7, 2024

Uh oh!

codecov bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

open-craft-grove commented Jun 26, 2024

Uh oh!

open-craft-grove commented Jun 26, 2024

Uh oh!

open-craft-grove commented Jun 26, 2024

Uh oh!

open-craft-grove commented Jun 26, 2024

Uh oh!

open-craft-grove commented Jun 26, 2024

Uh oh!

open-craft-grove commented Jun 29, 2024

Uh oh!

open-craft-grove commented Jun 29, 2024

Uh oh!

open-craft-grove commented Jun 29, 2024

Uh oh!

open-craft-grove commented Jun 29, 2024

Uh oh!

open-craft-grove commented Jun 29, 2024

Uh oh!

open-craft-grove commented Jun 30, 2024

Uh oh!

open-craft-grove commented Jun 30, 2024

Uh oh!

open-craft-grove commented Jun 30, 2024

Uh oh!

open-craft-grove commented Jun 30, 2024

Uh oh!

open-craft-grove commented Jun 30, 2024

Uh oh!

ihor-romaniuk Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

ihor-romaniuk Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Jul 2, 2024

Uh oh!

open-craft-grove commented Jul 2, 2024

Uh oh!

open-craft-grove commented Jul 3, 2024

Uh oh!

open-craft-grove commented Jul 3, 2024

Uh oh!

open-craft-grove commented Jul 3, 2024

Uh oh!

open-craft-grove commented Jul 3, 2024

Uh oh!

openedx-webhooks commented Jul 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PKulkoRaccoonGang commented May 27, 2024 •

edited

Loading

openedx-webhooks commented May 27, 2024 •

edited

Loading

codecov bot commented Jun 26, 2024 •

edited

Loading