-
Notifications
You must be signed in to change notification settings - Fork 6
Date extensions list #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Date extensions list #62
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 0.00% 73.78% +73.78%
==========================================
Files 5 32 +27
Lines 7 267 +260
Branches 0 59 +59
==========================================
+ Hits 0 197 +197
- Misses 7 70 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
120fcc7 to
00c39fb
Compare
1c84589 to
f075e8d
Compare
7c67309 to
d9574e2
Compare
wgu-jesse-stewart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good foundation for the date extensions feature! My main concerns are around query key caching; all courses and pages share the same query key, causing React Query to incorrectly return cached data from Course A when you navigate to Course B or switch pages. I'm approving, because I'm not actually sure if this is an issue without testing it.
The test coverage is solid, and the component structure is clean.
1d16948 to
388c7d8
Compare
c20cb7a to
1549033
Compare
1549033 to
2f05a62
Compare
2f05a62 to
8726fc3
Compare
Description
It covers the first and fourth point of the acceptance criteria for #30
A table lists all granted extensions with the following columns:
The list supports pagination with 25 per page.
Screenshot
Link to test when MFE is running: http://apps.local.openedx.io:8081/instructor/course-v1:OpenedX+DemoX+DemoCourse/date_extensions
Support Information
Closes #56