Skip to content

Conversation

@wgu-jesse-stewart
Copy link
Contributor

@wgu-jesse-stewart wgu-jesse-stewart commented Oct 1, 2025

Summary

Add Architecture Decision Record (ADR) documenting the unified REST API architecture for the Instructor Dashboard, including comprehensive mapping of 90 endpoints across 12 functional domains with service dependencies and migration status.

Details

This ADR captures the architectural design for consolidating instructor dashboard functionality into a modern, RESTful API structure and serves as the technical foundation for migrating the Instructor Dashboard from legacy Django views to a modern API-first architecture, enabling better frontend/backend separation and improved maintainability.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 1, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 1, 2025

Thanks for the pull request, @wgu-jesse-stewart!

This repository is currently maintained by @openedx/committers-frontend-app-instruct.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.36%. Comparing base (5b0d465) to head (555dd32).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main       #8       +/-   ##
==========================================
+ Coverage   0.00%   36.36%   +36.36%     
==========================================
  Files          5       13        +8     
  Lines          7       22       +15     
  Branches       0        1        +1     
==========================================
+ Hits           0        8        +8     
- Misses         7       14        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wgu-jesse-stewart wgu-jesse-stewart marked this pull request as ready for review October 1, 2025 20:39
@sarina sarina requested a review from feanil October 1, 2025 21:03
@sarina
Copy link
Contributor

sarina commented Oct 1, 2025

Hey @feanil could you take a look here and see if we're moving in the right direction? If you're crunched for release time letting us know ~when you could take a look would be helpful. 🙇🏻‍♀️

Copy link

@wgu-taylor-payne wgu-taylor-payne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is well laid out and organized. I don't have a good grasp on the data/models involved, which obviously inform the design, but here are some things to consider:

@wgu-taylor-payne
Copy link

Also, the commit for this ADR should be docs rather than feat (ref).

@wgu-jesse-stewart wgu-jesse-stewart changed the title feat: ADR instructor dashboard rest api architecture doc: ADR instructor dashboard rest api architecture Oct 2, 2025
@wgu-jesse-stewart wgu-jesse-stewart changed the title doc: ADR instructor dashboard rest api architecture docs: ADR instructor dashboard rest api architecture Oct 2, 2025
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Oct 2, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 2, 2025
Copy link

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some in-line comments, one thing missing from this set of tables is the intent of each of the verbs. It's hard to infer what would happen when an endpoint is called with a verb if there is not already an equivalent endpoint.

@wgu-jesse-stewart wgu-jesse-stewart force-pushed the adr-instructor-dashboard-rest-api-architecture branch from 099339b to 2ec5ad5 Compare October 6, 2025 17:18
@wgu-jesse-stewart
Copy link
Contributor Author

wgu-jesse-stewart commented Oct 6, 2025

@wgu-taylor-payne

Overall I think this is well laid out and organized. I don't have a good grasp on the data/models involved, which obviously inform the design, but here are some things to consider:

@feanil

Left some in-line comments, one thing missing from this set of tables is the intent of each of the verbs. It's hard to infer what would happen when an endpoint is called with a verb if there is not already an equivalent endpoint.

thank you for the feedback - I have updated the docs to address each comment

| DELETE | /api/instructor/v1/courses/{course_key}/forum/members | discussion, student.auth | Missing | N/A | Revoke forum moderation role from users |
+--------+--------------------------------------------------------------------+--------------------------------+-----------+-------------------------------------------------------------------+----------------------------------------------------------------------------------------------+

Student Administration API

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there some decision to call these "students" instead of "learners"? The term "learner" has always been preferred in the past, and that seems like a major change!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still be using "Learner" and not "Student".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll keep that in mind. Are we renaming the auth service or will all references to student remain in the code base? https://github.com/WGU-Open-edX/edx-platform/tree/master/common/djangoapps/student or any of the existing APIs that use the student naming convention?

Copy link

@bradenmacdonald bradenmacdonald Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, you're right that there's a lot of student in the codebase, though it's not user-facing. More than I remembered in fact :p

I do see this as an opportunity to align the backend names with the frontend names. It's like our ongoing effort in Authoring MFE to call things "units", "subsections" and "sections" (what users see) instead of "verticals", "sequentials", and "chapters". Whenever we add large new API surfaces, it's an opportunity to handle naming more consistently. So I think it's best to use "learner" here since that's what it will say in the UI.

Learner Administration API
^^^^^^^^^^^^^^^^^^^^^^^^^^

The ``GET /students/{username}`` endpoint will include ``enrollment_status`` and ``progress_url`` fields in the response. Separate endpoints for these single attributes are not needed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on my previous comment, I think it would be good to replace all the /students/ in the URLs here with /learners/ while we have the option, since it's a new API. Then the developer terminology is more in line with the user/operator terminology.

@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions Oct 29, 2025
@mphilbrick211
Copy link

Hi @wgu-jesse-stewart! Is this still in progress?

@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

7 participants