-
Notifications
You must be signed in to change notification settings - Fork 6
docs: ADR instructor dashboard rest api architecture #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: ADR instructor dashboard rest api architecture #8
Conversation
|
Thanks for the pull request, @wgu-jesse-stewart! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 0.00% 36.36% +36.36%
==========================================
Files 5 13 +8
Lines 7 22 +15
Branches 0 1 +1
==========================================
+ Hits 0 8 +8
- Misses 7 14 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @feanil could you take a look here and see if we're moving in the right direction? If you're crunched for release time letting us know ~when you could take a look would be helpful. 🙇🏻♀️ |
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is well laid out and organized. I don't have a good grasp on the data/models involved, which obviously inform the design, but here are some things to consider:
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
|
Also, the commit for this ADR should be |
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some in-line comments, one thing missing from this set of tables is the intent of each of the verbs. It's hard to infer what would happen when an endpoint is called with a verb if there is not already an equivalent endpoint.
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
099339b to
2ec5ad5
Compare
thank you for the feedback - I have updated the docs to address each comment |
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0003-instructor-dashboard-rest-api-architecture.rst
Outdated
Show resolved
Hide resolved
| | DELETE | /api/instructor/v1/courses/{course_key}/forum/members | discussion, student.auth | Missing | N/A | Revoke forum moderation role from users | | ||
| +--------+--------------------------------------------------------------------+--------------------------------+-----------+-------------------------------------------------------------------+----------------------------------------------------------------------------------------------+ | ||
|
|
||
| Student Administration API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there some decision to call these "students" instead of "learners"? The term "learner" has always been preferred in the past, and that seems like a major change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still be using "Learner" and not "Student".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll keep that in mind. Are we renaming the auth service or will all references to student remain in the code base? https://github.com/WGU-Open-edX/edx-platform/tree/master/common/djangoapps/student or any of the existing APIs that use the student naming convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, you're right that there's a lot of student in the codebase, though it's not user-facing. More than I remembered in fact :p
I do see this as an opportunity to align the backend names with the frontend names. It's like our ongoing effort in Authoring MFE to call things "units", "subsections" and "sections" (what users see) instead of "verticals", "sequentials", and "chapters". Whenever we add large new API surfaces, it's an opportunity to handle naming more consistently. So I think it's best to use "learner" here since that's what it will say in the UI.
| Learner Administration API | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| The ``GET /students/{username}`` endpoint will include ``enrollment_status`` and ``progress_url`` fields in the response. Separate endpoints for these single attributes are not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on my previous comment, I think it would be good to replace all the /students/ in the URLs here with /learners/ while we have the option, since it's a new API. Then the developer terminology is more in line with the user/operator terminology.
|
Hi @wgu-jesse-stewart! Is this still in progress? |
Summary
Add Architecture Decision Record (ADR) documenting the unified REST API architecture for the Instructor Dashboard, including comprehensive mapping of 90 endpoints across 12 functional domains with service dependencies and migration status.
Details
This ADR captures the architectural design for consolidating instructor dashboard functionality into a modern, RESTful API structure and serves as the technical foundation for migrating the Instructor Dashboard from legacy Django views to a modern API-first architecture, enabling better frontend/backend separation and improved maintainability.