Refactor imports to use src alias #80
Draft
+22
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the imports to use the
@srcalias we can have cleaner imports and do imports like this:import { useCourseInfo } from '@src/data/apiHook';instead of:
import { useCourseInfo } from '../../../data/apiHook';To achieve this it was needed to upgrade the
frontend-baseversion and that included aparagonversion upgrade to v23, some minor changes on styles were made to adopt this new version.Warning
Waiting on openedx/frontend-base#116 to be merge to upgrade to that version of frontend-base
Supporting information
It depends on openedx/frontend-base#116.
It closes #76.
Testing instructions
Make sure all the components load properly and all test passes.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'