Skip to content

feat: make this app compatible with rsbuild #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Apr 9, 2025

The webpack configuration used to include a weird line, that allowed all
non-implicit imports from src/. Such imports were ambiguous, and
required modification of the resolve path, which is unconventional.

To resolve this, we adopt the same solution as frontend-app-learning:
src/ imports are written as from '@src/...'.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

The webpack configuration used to include a weird line, that allowed all
non-implicit imports from src/. Such imports were ambiguous, and
required modification of the resolve path, which is unconventional.

To resolve this, we adopt the same solution as frontend-app-learning:
src/ imports are written as `from '@src/...'`.
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (a210f23) to head (9256877).
⚠️ Report is 61 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         152      152           
  Lines        1327     1327           
  Branches      219      219           
=======================================
  Hits         1293     1293           
  Misses         33       33           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 24, 2025
@itsjeyd itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Apr 24, 2025
@itsjeyd
Copy link

itsjeyd commented Jun 12, 2025

Hi @regisb, are you planning to continue working on this PR, or is it perhaps no longer needed?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Jun 12, 2025
@regisb
Copy link
Contributor Author

regisb commented Jun 16, 2025

If people agree on the suggested approach here, then I can update the PR and rebase it on top of master. I have added a PR description to make it clear what this is all about.

To clarify: the rsbuild PR depends on this one, but this PR is a win in all cases, because it simplifies the webpack configuration of the learner dashboard MFE.

@itsjeyd
Copy link

itsjeyd commented Jul 24, 2025

Thanks @regisb.

@openedx/2u-aperture This PR is still in draft state but could you please give it a first look and see if you're good with the general approach?

@itsjeyd itsjeyd added needs maintainer attention Issue or PR specifically needs the attention of the maintainer. and removed inactive PR author has been unresponsive for several months labels Jul 24, 2025
@itsjeyd itsjeyd moved this from Waiting on Author to Ready for Review in Contributions Jul 24, 2025
@MaxFrank13
Copy link
Member

Thanks @regisb.

@openedx/2u-aperture This PR is still in draft state but could you please give it a first look and see if you're good with the general approach?

This approach looks good to me. The way it is currently set up definitely can cause some confusion and this change will make it easier to grok.

I notice that the webpack.prod.config file for this MFE is different than the one for the Learning MFE when it comes to handling the @src alias. Would we want these to be consistent with each other? It seems like two implementations to accomplish the same thing from what I can tell, but perhaps I'm missing something.

Thanks for the contribution, @regisb!

@jsnwesson jsnwesson added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Aug 5, 2025
@itsjeyd itsjeyd moved this from Ready for Review to Waiting on Author in Contributions Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: No status
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

5 participants