-
Notifications
You must be signed in to change notification settings - Fork 148
feat: make this app compatible with rsbuild #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The webpack configuration used to include a weird line, that allowed all non-implicit imports from src/. Such imports were ambiguous, and required modification of the resolve path, which is unconventional. To resolve this, we adopt the same solution as frontend-app-learning: src/ imports are written as `from '@src/...'`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 152 152
Lines 1327 1327
Branches 219 219
=======================================
Hits 1293 1293
Misses 33 33
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @regisb, are you planning to continue working on this PR, or is it perhaps no longer needed? |
If people agree on the suggested approach here, then I can update the PR and rebase it on top of master. I have added a PR description to make it clear what this is all about. To clarify: the rsbuild PR depends on this one, but this PR is a win in all cases, because it simplifies the webpack configuration of the learner dashboard MFE. |
Thanks @regisb. @openedx/2u-aperture This PR is still in draft state but could you please give it a first look and see if you're good with the general approach? |
This approach looks good to me. The way it is currently set up definitely can cause some confusion and this change will make it easier to grok. I notice that the Thanks for the contribution, @regisb! |
The webpack configuration used to include a weird line, that allowed all
non-implicit imports from src/. Such imports were ambiguous, and
required modification of the resolve path, which is unconventional.
To resolve this, we adopt the same solution as frontend-app-learning:
src/ imports are written as
from '@src/...'
.