Add advertised start date on course card#619
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 152 152
Lines 1332 1332
Branches 229 229
=======================================
Hits 1299 1299
Misses 32 32
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b2ac1f to
e59a91f
Compare
8f6789c to
df8e2b0
Compare
|
Hi @openedx/2u-aperture can someone help with this review? thanks 😄 |
df8e2b0 to
b8d8ccb
Compare
b8d8ccb to
148aea5
Compare
148aea5 to
8329c95
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds the advertised start date display logic to the course card by updating the endpoint response, selector mappings, and UI hooks.
- Updated tests to verify the advertised start date is passed through the selector.
- Modified the course card selector to include the advertised start date.
- Adjusted the course card hook to check for and use the advertised start date.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/data/redux/app/selectors/courseCard.test.js | Added test cases to check for the advertised start date. |
| src/data/redux/app/selectors/courseCard.js | Updated the selector to pass the advertised start date through. |
| src/containers/CourseCard/components/CourseCardDetails/hooks.js | Modified hook logic to conditionally use advertised start date. |
| (courseRun) => (courseRun === null ? {} : { | ||
| endDate: module.loadDateVal(courseRun.endDate), | ||
| startDate: module.loadDateVal(courseRun.startDate), | ||
| advertisedStart: courseRun.advertisedStart, |
There was a problem hiding this comment.
Consider converting advertisedStart using loadDateVal (or a similar conversion) if it represents a standard date format, to ensure consistency with startDate and endDate. If the field is intentionally a pre-formatted string, please add a comment to clarify this behavior.
| advertisedStart: courseRun.advertisedStart, | |
| advertisedStart: module.loadDateVal(courseRun.advertisedStart), |
There was a problem hiding this comment.
it can be any text, so we don't need to do a conversion
MaxFrank13
left a comment
There was a problem hiding this comment.
Tested this alongside the changes to the backend in edx-platform. Everything worked as expected. Thanks for the contribution!
|
We're actually currently running a small Copilot pilot program that the WGU team is a part of. @feanil is in charge of the program. |
8329c95 to
0932c25
Compare
Description
Currently advertised start date wasn't showing at all on course card or even receiving the value from the endpoints, to accomplish this we had to add that value on the endpoint response and only if a started date was added is showed, if not it falls back to show start date.
Screenshots
Without advertised start date:

With advertised start date:

Support Information
This PR fixes #558
Related PR
Backend Change: openedx/openedx-platform#36726