Skip to content

Add advertised start date on course card#619

Merged
MaxFrank13 merged 2 commits intoopenedx:masterfrom
diana-villalvazo-wgu:558/advertised-start
May 23, 2025
Merged

Add advertised start date on course card#619
MaxFrank13 merged 2 commits intoopenedx:masterfrom
diana-villalvazo-wgu:558/advertised-start

Conversation

@diana-villalvazo-wgu
Copy link
Contributor

Description

Currently advertised start date wasn't showing at all on course card or even receiving the value from the endpoints, to accomplish this we had to add that value on the endpoint response and only if a started date was added is showed, if not it falls back to show start date.

Screenshots

Without advertised start date:
Screenshot 2025-05-15 at 5 40 04 p m

With advertised start date:
Screenshot 2025-05-15 at 5 40 48 p m

Support Information

This PR fixes #558

Related PR

Backend Change: openedx/openedx-platform#36726

@diana-villalvazo-wgu diana-villalvazo-wgu requested a review from a team as a code owner May 15, 2025 23:46
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 15, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (2f3f3bc) to head (0932c25).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         152      152           
  Lines        1332     1332           
  Branches      229      229           
=======================================
  Hits         1299     1299           
  Misses         32       32           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vmnavarro94 vmnavarro94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label May 16, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions May 16, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 558/advertised-start branch 2 times, most recently from 8f6789c to df8e2b0 Compare May 16, 2025 15:42
@diana-villalvazo-wgu
Copy link
Contributor Author

Hi @openedx/2u-aperture can someone help with this review? thanks 😄

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the advertised start date display logic to the course card by updating the endpoint response, selector mappings, and UI hooks.

  • Updated tests to verify the advertised start date is passed through the selector.
  • Modified the course card selector to include the advertised start date.
  • Adjusted the course card hook to check for and use the advertised start date.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/data/redux/app/selectors/courseCard.test.js Added test cases to check for the advertised start date.
src/data/redux/app/selectors/courseCard.js Updated the selector to pass the advertised start date through.
src/containers/CourseCard/components/CourseCardDetails/hooks.js Modified hook logic to conditionally use advertised start date.

(courseRun) => (courseRun === null ? {} : {
endDate: module.loadDateVal(courseRun.endDate),
startDate: module.loadDateVal(courseRun.startDate),
advertisedStart: courseRun.advertisedStart,
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider converting advertisedStart using loadDateVal (or a similar conversion) if it represents a standard date format, to ensure consistency with startDate and endDate. If the field is intentionally a pre-formatted string, please add a comment to clarify this behavior.

Suggested change
advertisedStart: courseRun.advertisedStart,
advertisedStart: module.loadDateVal(courseRun.advertisedStart),

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be any text, so we don't need to do a conversion

Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this alongside the changes to the backend in edx-platform. Everything worked as expected. Thanks for the contribution!

@deborahgu
Copy link
Member

Hi, @tonybusa, per Axim (via @sarina), though we cannot disable "request reviews from copilot", Axim requests that we don't do it. Thank you!

@sarina
Copy link

sarina commented May 22, 2025

We're actually currently running a small Copilot pilot program that the WGU team is a part of. @feanil is in charge of the program.

@deborahgu
Copy link
Member

We're actually currently running a small Copilot pilot program that the WGU team is a part of. @feanil is in charge of the program.

good to know, thanks! Sorry, @tonybusa.

@MaxFrank13 MaxFrank13 merged commit 66794ac into openedx:master May 23, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Aperture-Maintained May 23, 2025
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 23, 2025
@openedx-webhooks openedx-webhooks removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 23, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the 558/advertised-start branch May 23, 2025 20:08
jignaciopm pushed a commit to eduNEXT/frontend-app-learner-dashboard that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

Start date does not reflect "Course advertised start" advanced setting

8 participants