build: Upgrade to Node 24 by PKulkoRaccoonGang · Pull Request #1753 · openedx/frontend-app-learning

PKulkoRaccoonGang · 2025-07-06T13:23:17Z

Description

As a second step in the Node 24 upgrade process, upgrade .nvmrc and regenerate package-lock.json from scratch using Node 24. Also make the Node 24 test a blocking one.

See the tracking issue for futher information.

openedx-webhooks · 2025-07-06T13:23:21Z

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-07-06T13:28:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (d3188ef) to head (c055b88).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1753   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         344      344           
  Lines        5794     5794           
  Branches     1374     1374           
=======================================
  Hits         5263     5263           
  Misses        512      512           
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

PKulkoRaccoonGang · 2025-07-07T07:49:10Z

jest.config.js


-// delete config.testURL;
-
-config.reporters = [...(config.reporters || []), ["jest-console-group-reporter", {


Removing the configuration for jest-console-group-reporter caused this error

TypeError: Cannot read properties of undefined (reading 'isSet') at SummaryReporter._getTestSummary (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/reporters/build/index.js:1560:33) at SummaryReporter.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/reporters/build/index.js:1506:104) at JestConsoleGroupReporter.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/jest-console-group-reporter/dist/index.js:476:30) at ReporterDispatcher.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/ReporterDispatcher.js:71:24) at TestScheduler.scheduleTests (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/TestScheduler.js:306:28) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async runJest (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/runJest.js:367:19) at async _run10000 (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/cli/index.js:343:7) at async runCLI (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/cli/index.js:198:3) at async Object.run (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/jest-cli/build/run.js:130:37)

I searched the OeX repositories where jest-console-group-reporter is still used and it turned out that this is the only repository where logging is improved due to this package.

I suggest getting rid of this.

PKulkoRaccoonGang · 2025-09-23T07:35:58Z

In draft until the warning issue is resolved

PKulkoRaccoonGang · 2025-10-03T07:59:19Z

package.json

    "@edx/frontend-component-header": "^6.2.0",
    "@edx/frontend-lib-learning-assistant": "^2.23.0",
-    "@edx/frontend-lib-special-exams": "^4.0.0",
+    "@edx/frontend-lib-special-exams": "4.0.0",


[inform]: I encountered some problems with the tests related to @edx/frontend-lib-special-exams and @openedx/paragon. I managed to solve them by removing the caret (^), but I'm still trying to figure out the cause of the problems.

PKulkoRaccoonGang · 2025-10-06T06:44:46Z

Since the issues discovered during the package-lock.json regeneration are not related to the Node.js 24 upgrade, it was decided to update Node.js in a separate PR :#1800.

The identified problems have been documented in a new issue: #1801.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 6, 2025

openedx-webhooks added this to Contributions Jul 6, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jul 6, 2025

PKulkoRaccoonGang self-assigned this Jul 6, 2025

PKulkoRaccoonGang force-pushed the Peter_Kulko/node24-upgrade-2 branch from cabf862 to c8647b3 Compare July 6, 2025 13:24

PKulkoRaccoonGang changed the title ~~Peter kulko/node24 upgrade 2~~ build: Upgrade to Node 24 Jul 6, 2025

PKulkoRaccoonGang commented Jul 7, 2025

View reviewed changes

PKulkoRaccoonGang requested review from arbrandes and bradenmacdonald and removed request for bradenmacdonald July 7, 2025 07:50

PKulkoRaccoonGang mentioned this pull request Jul 7, 2025

test: Remove support for Node 20 #1754

Closed

itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jul 24, 2025

openedx-webhooks removed the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jul 24, 2025

itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Jul 24, 2025

itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Jul 24, 2025

itsjeyd mentioned this pull request Jul 24, 2025

openedx-webhooks only considers repo-specific info for labeling and rejects manual overrides openedx/wg-governance#159

Closed

itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Aug 18, 2025

cmltaWt0 mentioned this pull request Jul 6, 2025

Node 24 upgrade #1735

Closed

2 tasks

bydawen force-pushed the Peter_Kulko/node24-upgrade-2 branch 5 times, most recently from 369b4c8 to 32d3504 Compare September 19, 2025 20:27

PKulkoRaccoonGang marked this pull request as ready for review September 22, 2025 08:08

PKulkoRaccoonGang marked this pull request as draft September 22, 2025 15:57

PKulkoRaccoonGang force-pushed the Peter_Kulko/node24-upgrade-2 branch 2 times, most recently from 10b591e to 3adc3e7 Compare September 23, 2025 06:59

itsjeyd removed the blocked by other work PR cannot be finished until other work is complete label Sep 23, 2025

PKulkoRaccoonGang force-pushed the Peter_Kulko/node24-upgrade-2 branch from 4c293b9 to 1e996ae Compare September 29, 2025 15:26

PKulkoRaccoonGang removed the request for review from arbrandes September 30, 2025 08:46

build: Upgrade to Node 24

c055b88

PKulkoRaccoonGang force-pushed the Peter_Kulko/node24-upgrade-2 branch from af24e6a to c055b88 Compare September 30, 2025 08:58

PKulkoRaccoonGang commented Oct 3, 2025

View reviewed changes

PKulkoRaccoonGang mentioned this pull request Oct 6, 2025

Incompatibilities introduced by dependency updates after regenerating package-lock.json #1801

Closed

PKulkoRaccoonGang closed this Oct 6, 2025

github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 6, 2025

PKulkoRaccoonGang mentioned this pull request Feb 4, 2026

feat: fixes after package-lock regen #1837

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Upgrade to Node 24#1753

build: Upgrade to Node 24#1753
PKulkoRaccoonGang wants to merge 1 commit intoopenedx:masterfrom
raccoongang:Peter_Kulko/node24-upgrade-2

PKulkoRaccoonGang commented Jul 6, 2025 •

edited

Loading

Uh oh!

openedx-webhooks commented Jul 6, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 6, 2025 •

edited

Loading

Uh oh!

PKulkoRaccoonGang Jul 7, 2025

Uh oh!

arbrandes Oct 2, 2025

Uh oh!

PKulkoRaccoonGang commented Sep 23, 2025 •

edited

Loading

Uh oh!

PKulkoRaccoonGang Oct 3, 2025

Uh oh!

PKulkoRaccoonGang commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		// delete config.testURL;

		config.reporters = [...(config.reporters \|\| []), ["jest-console-group-reporter", {

Conversation

PKulkoRaccoonGang commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openedx-webhooks commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

PKulkoRaccoonGang Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

arbrandes Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

PKulkoRaccoonGang commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PKulkoRaccoonGang Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

PKulkoRaccoonGang commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PKulkoRaccoonGang commented Jul 6, 2025 •

edited

Loading

openedx-webhooks commented Jul 6, 2025 •

edited

Loading

codecov bot commented Jul 6, 2025 •

edited

Loading

PKulkoRaccoonGang commented Sep 23, 2025 •

edited

Loading