Skip to content

build: Upgrade to Node 24 #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

build: Upgrade to Node 24 #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed5c86
test: Add Node 24 to CI matrix
PKulkoRaccoonGang Jul 6, 2025
c8647b3
build: Upgrade to Node 24
PKulkoRaccoonGang Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,19 @@ on:
jobs:
tests:
runs-on: ubuntu-latest
strategy:
matrix:
node: [20, 24]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version: ${{ matrix.node }}
- run: make validate.ci
- name: Archive code coverage results
uses: actions/upload-artifact@v4
with:
name: code-coverage-report
name: code-coverage-report-node-${{ matrix.node }}
path: coverage/*.*
coverage:
runs-on: ubuntu-latest
Expand All @@ -28,7 +31,8 @@ jobs:
- name: Download code coverage results
uses: actions/download-artifact@v4
with:
name: code-coverage-report
pattern: code-coverage-report-node-*
merge-multiple: true
- name: Upload coverage
uses: codecov/codecov-action@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
24
18 changes: 0 additions & 18 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,4 @@ const config = createConfig('jest', {
testEnvironment: 'jsdom',
});

// delete config.testURL;

config.reporters = [...(config.reporters || []), ["jest-console-group-reporter", {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the configuration for jest-console-group-reporter caused this error

TypeError: Cannot read properties of undefined (reading 'isSet')
    at SummaryReporter._getTestSummary (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/reporters/build/index.js:1560:33)
    at SummaryReporter.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/reporters/build/index.js:1506:104)
    at JestConsoleGroupReporter.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/jest-console-group-reporter/dist/index.js:476:30)
    at ReporterDispatcher.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/ReporterDispatcher.js:71:24)
    at TestScheduler.scheduleTests (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/TestScheduler.js:306:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runJest (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/runJest.js:367:19)
    at async _run10000 (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/cli/index.js:343:7)
    at async runCLI (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/cli/index.js:198:3)
    at async Object.run (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/jest-cli/build/run.js:130:37)

I searched the OeX repositories where jest-console-group-reporter is still used and it turned out that this is the only repository where logging is improved due to this package.

I suggest getting rid of this.

// change this setting if need to see less details for each test
// reportType: "summary" | "details",
// enable: true | false,
afterEachTest: {
enable: true,
filePaths: false,
reportType: "details",
},
afterAllTests: {
reportType: "summary",
enable: true,
filePaths: true,
},
}]];

module.exports = config;
Loading