-
Notifications
You must be signed in to change notification settings - Fork 304
fix: ensure full-height layout #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure full-height layout #1724
Conversation
|
Thanks for the pull request, @wgu-jesse-stewart! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 90.42% 90.44% +0.02%
==========================================
Files 344 344
Lines 5785 5801 +16
Branches 1348 1395 +47
==========================================
+ Hits 5231 5247 +16
+ Misses 537 535 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes the full-height layout issue for the course sequence sidebar by adjusting CSS rules and refining component structure. Key changes include:
- Updating CSS to use new viewport height units and a revised flex layout.
- Removing an unnecessary wrapper div in the NoticesProvider component.
- Refactoring the layout structure in Sequence.jsx to separate the SequenceExamWrapper and CourseLicense components.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.scss | Updated CSS with new 100svh unit and added #main-content flex styling to improve layout responsiveness. |
| src/generic/notices/NoticesProvider.jsx | Removed an unnecessary wrapper div for clearer component rendering. |
| src/courseware/course/sidebar/sidebars/course-outline/CourseOutlineTray.scss | Removed overflow and absolute positioning styling to support the new sidebar layout. |
| src/courseware/course/sequence/Sequence.jsx | Adjusted the component structure to reallocate layout responsibilities between SequenceExamWrapper and CourseLicense. |
Comments suppressed due to low confidence (2)
src/courseware/course/sidebar/sidebars/course-outline/CourseOutlineTray.scss:3
- Removing the 'overflow: auto' property may lead to issues if the sidebar content exceeds the available space, causing potential overflow. Consider verifying that this change does not negatively impact the usability of longer navigation lists or apply a conditional overflow handling.
- overflow: auto;
src/courseware/course/sequence/Sequence.jsx:233
- Moving the CourseLicense component outside of the flex container may affect the intended alignment and spacing within the sequence layout. Please confirm that this change meets the layout requirements across different content scenarios.
<CourseLicense license={license || undefined} />
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for addressing the feedback!
In addition to the inline question, can you please bump frontend-lib-special-exams to ^4.0.0 in package.json?
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me! Approved!
Absolutely! 🤜🤛 Thanks for helping me get these merged! |
Fixes #1695
Related PR: openedx/frontend-lib-special-exams#164
Summary:
When content within a sequence is shorter than the height of the browser viewport, the .sequence-container > .outline-sidebar-wrapper element does not expand appropriately. This causes the course outline sidebar to be partially or completely hidden from view.
Steps to Reproduce:
Open a course sequence that contains very little content (e.g., a short paragraph or notice).
View the course in a tall browser window.
Observe that the sidebar navigation is cut off or hidden.
Expected Behavior:
The sidebar should remain fully visible and accessible, regardless of the amount of content in the main pane.
Actual Behavior:
When the content is short, the parent container height collapses to fit that content, which in turn restricts the sidebar’s height, hiding part of the navigation.
Screenshots:


Removing unnecessary wrapper divs and adding some very specific CSS to target the layout parent.
Demo of fix:
https://github.com/user-attachments/assets/627061e0-bb17-459e-af57-fb9a5c1175a9