fix: codespaces devstack collision port 2000#1731
Closed
papphelix wants to merge 8 commits intoopenedx:masterfrom
Closed
fix: codespaces devstack collision port 2000#1731papphelix wants to merge 8 commits intoopenedx:masterfrom
papphelix wants to merge 8 commits intoopenedx:masterfrom
Conversation
This reverts commit 1412bfe.
…collision on 2000 port
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
- Coverage 90.45% 90.44% -0.01%
==========================================
Files 344 344
Lines 5802 5801 -1
Branches 1398 1398
==========================================
- Hits 5248 5247 -1
- Misses 535 537 +2
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@papphelix - I'm going to close this PR for now. I believe we want to learn a bit more before proposing this change for the community. In the meantime, you can move this to the 2U fork: https://github.com/edx/frontend-app-learning. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Codespaces devstack has a collision with Learning MFE for port 2000
So implemented development port changed to 2010 port.