feat: add plugin slot for content iframe error component #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenk
force-pushed
the
jkantor/unit-error-slot
branch
from
49e16c7 to
25b0ddb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
=======================================
Coverage 90.38% 90.39%
=======================================
Files 344 345 +1
Lines 5811 5817 +6
Branches 1355 1398 +43
=======================================
+ Hits 5252 5258 +6
+ Misses 542 540 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new plugin slot to enable customization of the error page displayed when content iframe fails to load in the learning application. The plugin slot allows developers to replace or modify the default error page with custom implementations.
- Creates a new
ContentIFrameErrorSlotplugin slot component with slot IDorg.openedx.frontend.learning.content_iframe_error.v1 - Replaces the direct usage of
ErrorPagecomponent with the new plugin slot in theContentIFramecomponent - Provides documentation and configuration examples for the new plugin slot
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plugin-slots/ContentIFrameErrorSlot/index.tsx | Creates the new plugin slot component that wraps ErrorPage as default content |
| src/plugin-slots/ContentIFrameErrorSlot/README.md | Provides documentation and usage examples for the plugin slot |
| src/courseware/course/sequence/Unit/ContentIFrame.jsx | Updates error handling to use the new plugin slot instead of ErrorPage directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a plugin slot,
org.openedx.frontend.learning.content_iframe_error.v1to enable customization via plugins of the error page shown when the unit iframe fails to load.