Skip to content

E0d/i18n fixes #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FileUpload/FileMetaDisplay.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const FileMetaDisplay = ({ name, description, size }) => (
<div className="file-meta-option">
<strong><FormattedMessage {...messages.fileSizeTitle} /></strong>
<br />
{typeof (size) === 'number' ? filesize(size) : 'Unknown'}
{typeof (size) === 'number' ? filesize(size) : <FormattedMessage {...messages.unknownFileSize} />}
</div>
</>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ exports[`<FileMetaDisplay /> render file meta display with no size 1`] = `
/>
</strong>
<br />
Unknown
<FormattedMessage
defaultMessage="Unknown"
description="Label for unknown file size"
id="frontend-app-ora.FileCellContent.unknownFileSize"
/>
</div>
</Fragment>
`;
5 changes: 5 additions & 0 deletions src/components/FileUpload/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ const messages = defineMessages({
defaultMessage: 'File size',
description: ' title for file size',
},
unknownFileSize: {
id: 'frontend-app-ora.FileCellContent.unknownFileSize',
defaultMessage: 'Unknown',
description: 'Label for unknown file size',
},
fileUploadTitle: {
id: 'frontend-app-ora.FileCellContent.fileUploadTitle',
defaultMessage: 'File upload',
Expand Down
4 changes: 3 additions & 1 deletion src/components/ProgressBar/ProgressStep.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import classNames from 'classnames';

import { StrictDict } from '@edx/react-unit-test-utils';
import { Nav, Icon } from '@openedx/paragon';
import { FormattedMessage } from '@edx/frontend-platform/i18n';
import {
CheckCircle,
Edit,
Expand All @@ -14,6 +15,7 @@ import {

import { stepNames } from 'constants/index';
import { useProgressStepData } from './hooks';
import messages from './messages';

export const stepIcons = StrictDict({
[stepNames.submission]: Edit,
Expand Down Expand Up @@ -43,7 +45,7 @@ const ProgressStep = ({
if (isPastDue) {
colorClass = 'text-danger-500';
iconSrc = Error;
subLabel = 'Past due!';
subLabel = <FormattedMessage {...messages.pastDue} />;
} else if (isComplete) {
iconSrc = CheckCircle;
if (step === stepNames.done && myGrade) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ exports[`<ProgressStep /> render error on past due 1`] = `
className="x-small m-0 text-danger-500"
data-testid="sublabel-test-id"
>
Past due!
<FormattedMessage
defaultMessage="Past due!"
description="Warning label shown when a step is past its due date"
id="frontend-app-ora.ProgressBar.pastDue"
/>
</p>
</div>
</Nav.Link>
Expand Down
5 changes: 5 additions & 0 deletions src/components/ProgressBar/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ const messages = defineMessages({
defaultMessage: ' (Step {stepIndex}/{totalSteps})',
description: 'Step progress indicator',
},
pastDue: {
id: 'frontend-app-ora.ProgressBar.pastDue',
defaultMessage: 'Past due!',
description: 'Warning label shown when a step is past its due date',
},
});

export default messages;
2 changes: 1 addition & 1 deletion src/views/XBlockStudioView/components/StudioViewTitle.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const StudioViewTitle = () => {

return (
<div className="block-title">
<h2>{title}</h2>
<h2>{formatMessage(messages.blockTitle, { title })}</h2>
<Button
className="flex-grow"
onClick={toggleAll}
Expand Down
5 changes: 5 additions & 0 deletions src/views/XBlockStudioView/components/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ import { defineMessages } from '@edx/frontend-platform/i18n';
import { stepNames } from 'constants/index';

const messages = defineMessages({
blockTitle: {
id: 'frontend-app-ora.xblock-studio-view.blockTitle',
defaultMessage: '{title}',
description: 'Title of the Open Response Assessment block',
},
promptHeader: {
defaultMessage: 'Prompt',
description: 'prompt header',
Expand Down
Loading