Skip to content

refactor: replaced injectIntl with useIntl #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Simoblaster
Copy link

This pull request resolves issue #1238

I replaced the deprecated "injectIntl" with the "useIntl()" hook and I have created tests.

@Simoblaster Simoblaster requested a review from a team as a code owner July 17, 2025 22:03
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 17, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 17, 2025

Thanks for the pull request, @Simoblaster!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Simoblaster
Copy link
Author

I signed the contributor agreement :)

@deborahgu deborahgu moved this to Backlog in Aperture-Maintained Jul 21, 2025
@Simoblaster
Copy link
Author

@diana-villalvazo-wgu There are any issues with my pr? I'm not able to tag @openedx/cla-problems for let them know about my signed contributor agreement

@diana-villalvazo-wgu
Copy link

@diana-villalvazo-wgu There are any issues with my pr? I'm not able to tag @openedx/cla-problems for let them know about my signed contributor agreement

Hi @Simoblaster can you make some changes on title or push new commits to re-run the cla check? so we can see if it passes now?

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jul 29, 2025
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 29, 2025
@sarina
Copy link
Contributor

sarina commented Aug 1, 2025

@Simoblaster we don't have your CLA in our records. When you visited http://openedx.org/cla, it should have generated a DocuSign form that would have arrived in your email, and you would then need to sign that form. Did you do the second step?

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 4, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Aug 4, 2025
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Needs Tests Run or CLA Signed in Contributions Aug 4, 2025
@Simoblaster
Copy link
Author

@Simoblaster we don't have your CLA in our records. When you visited http://openedx.org/cla, it should have generated a DocuSign form that would have arrived in your email, and you would then need to sign that form. Did you do the second step?

Yes! I did it now

@sarina
Copy link
Contributor

sarina commented Aug 6, 2025

@Simoblaster it'll take 1-2 days to process the CLA; in the meantime I recommend addressing the linting failures in the tests.

@sarina
Copy link
Contributor

sarina commented Aug 6, 2025

@Simoblaster I kicked off the tests for you. Please note we use Conventional Commits so you'll need to edit your commit message for that test to pass. See https://docs.openedx.org/en/latest/developers/references/developer_guide/process/landing-your-work.html for more details!

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.09%. Comparing base (58e1401) to head (99b2133).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
+ Coverage   72.89%   74.09%   +1.19%     
==========================================
  Files          49       49              
  Lines         797      799       +2     
  Branches      219      221       +2     
==========================================
+ Hits          581      592      +11     
+ Misses        205      196       -9     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simoblaster Simoblaster force-pushed the refactor/use-intl-hook branch from 61e6f87 to 99b2133 Compare August 7, 2025 08:05
@sarina
Copy link
Contributor

sarina commented Aug 11, 2025

Closing & re-opening to re-run the CLA check.

@sarina sarina closed this Aug 11, 2025
@github-project-automation github-project-automation bot moved this from Needs Tests Run or CLA Signed to Done in Contributions Aug 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Aperture-Maintained Aug 11, 2025
@sarina sarina reopened this Aug 11, 2025
@sarina sarina moved this from Done to Todo in Aperture-Maintained Aug 11, 2025
@sarina sarina moved this from Done to Ready for Review in Contributions Aug 11, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu requested a review from a team August 12, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Todo
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

5 participants