-
Notifications
You must be signed in to change notification settings - Fork 125
refactor: replaced injectIntl with useIntl #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @Simoblaster! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
I signed the contributor agreement :) |
@diana-villalvazo-wgu There are any issues with my pr? I'm not able to tag @openedx/cla-problems for let them know about my signed contributor agreement |
Hi @Simoblaster can you make some changes on title or push new commits to re-run the cla check? so we can see if it passes now? |
@Simoblaster we don't have your CLA in our records. When you visited http://openedx.org/cla, it should have generated a DocuSign form that would have arrived in your email, and you would then need to sign that form. Did you do the second step? |
Yes! I did it now |
@Simoblaster it'll take 1-2 days to process the CLA; in the meantime I recommend addressing the linting failures in the tests. |
@Simoblaster I kicked off the tests for you. Please note we use Conventional Commits so you'll need to edit your commit message for that test to pass. See https://docs.openedx.org/en/latest/developers/references/developer_guide/process/landing-your-work.html for more details! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
+ Coverage 72.89% 74.09% +1.19%
==========================================
Files 49 49
Lines 797 799 +2
Branches 219 221 +2
==========================================
+ Hits 581 592 +11
+ Misses 205 196 -9
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
61e6f87
to
99b2133
Compare
Closing & re-opening to re-run the CLA check. |
This pull request resolves issue #1238
I replaced the deprecated "injectIntl" with the "useIntl()" hook and I have created tests.