Skip to content

fix: adding typing delay to associated users table #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiram15 merged 3 commits into from
Jan 24, 2025
Merged

fix: adding typing delay to associated users table #443

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bedfdda
fix: adding typing delay to associated users table
kiram15 Jan 21, 2025
7a9423d
fix: PR request
kiram15 Jan 22, 2025
f06d55b
fix: adding test
kiram15 Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Configuration/Customers/data/hooks/useCustomerUsersTableData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,13 @@
setIsLoading(false);
}
};

if (enterpriseUuid) {
fetch();
if (args.filters.length && args.filters[0].value.length > 2) {
Copy link

@marlonkeating marlonkeating Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] Do we know that the typing filter will always be first in the list of filters?

Copy link
Contributor Author

@kiram15 kiram15 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, its the only filter we have for this table

fetch();

Check warning on line 62 in src/Configuration/Customers/data/hooks/useCustomerUsersTableData.js

View check run for this annotation

Codecov / codecov/patch

src/Configuration/Customers/data/hooks/useCustomerUsersTableData.js#L62 

Added line #L62 was not covered by tests
} else if (!args.filters.length) {
fetch();

Check warning on line 64 in src/Configuration/Customers/data/hooks/useCustomerUsersTableData.js

View check run for this annotation

Codecov / codecov/patch

src/Configuration/Customers/data/hooks/useCustomerUsersTableData.js#L64 

Added line #L64 was not covered by tests
}
}
}, [enterpriseUuid]);

Expand Down
Loading