feat: remove PII from urls #452
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { mount } from 'enzyme'; | ||
| import React from 'react'; | ||
| import { MemoryRouter } from 'react-router-dom'; | ||
| import { IntlProvider } from '@edx/frontend-platform/i18n'; | ||
| import { waitFor } from '@testing-library/react'; | ||
| import UserMessagesProvider from '../userMessages/UserMessagesProvider'; | ||
| import UserPage from './UserPage'; | ||
| import * as ssoAndUserApi from './data/api'; | ||
| import UserSummaryData from './data/test/userSummary'; | ||
| import verifiedNameHistoryData from './data/test/verifiedNameHistory'; | ||
| import onboardingStatusData from './data/test/onboardingStatus'; | ||
| import { entitlementsData } from './data/test/entitlements'; | ||
| import enterpriseCustomerUsersData from './data/test/enterpriseCustomerUsers'; | ||
| import { enrollmentsData } from './data/test/enrollments'; | ||
| import ssoRecordsData from './data/test/ssoRecords'; | ||
| import licensesData from './data/test/licenses'; | ||
|
|
||
| const mockedNavigator = jest.fn(); | ||
|
|
||
| jest.mock('react-router-dom', () => ({ | ||
| ...jest.requireActual('react-router-dom'), | ||
| useNavigate: () => mockedNavigator, | ||
| })); | ||
|
|
||
| const UserPageWrapper = () => ( | ||
| <MemoryRouter> | ||
| <IntlProvider locale="en"> | ||
| <UserMessagesProvider> | ||
| <UserPage /> | ||
| </UserMessagesProvider> | ||
| </IntlProvider> | ||
| </MemoryRouter> | ||
| ); | ||
|
|
||
| describe('User Page', () => { | ||
| let wrapper; | ||
| let mockedGetUserData; | ||
| beforeEach(() => { | ||
| mockedGetUserData = jest.spyOn(ssoAndUserApi, 'getAllUserData').mockImplementation(() => Promise.resolve({ user: UserSummaryData.userData, errors: [] })); | ||
| jest.spyOn(ssoAndUserApi, 'getVerifiedNameHistory').mockImplementation(() => Promise.resolve(verifiedNameHistoryData)); | ||
| jest.spyOn(ssoAndUserApi, 'getEnrollments').mockImplementation(() => Promise.resolve(enrollmentsData)); | ||
| jest.spyOn(ssoAndUserApi, 'getOnboardingStatus').mockImplementation(() => Promise.resolve(onboardingStatusData)); | ||
| jest.spyOn(ssoAndUserApi, 'getSsoRecords').mockImplementation(() => Promise.resolve(ssoRecordsData)); | ||
| jest.spyOn(ssoAndUserApi, 'getLicense').mockImplementation(() => Promise.resolve(licensesData)); | ||
| jest.spyOn(ssoAndUserApi, 'getEntitlements').mockImplementation(() => Promise.resolve(entitlementsData)); | ||
| jest.spyOn(ssoAndUserApi, 'getEnterpriseCustomerUsers').mockImplementation(() => Promise.resolve(enterpriseCustomerUsersData)); | ||
|
|
||
| jest.clearAllMocks(); | ||
|
Contributor
There was a problem hiding this comment. Shouldn't we have this in afterEach?
Contributor
Author
There was a problem hiding this comment. I feel like it is fine in both |
||
| }); | ||
|
|
||
| it('default render', async () => { | ||
| wrapper = mount(<UserPageWrapper />); | ||
| wrapper.find( | ||
| "input[name='userIdentifier']", | ||
| ).instance().value = 'AnonyMouse'; | ||
| wrapper.find('.btn.btn-primary').simulate('click'); | ||
|
|
||
| await waitFor(() => { | ||
| expect(mockedNavigator).toHaveBeenCalledWith( | ||
| `/learner_information/?lms_user_id=${UserSummaryData.userData.id}`, | ||
| ); | ||
|
Comment on lines
+58
to
+61
Contributor
There was a problem hiding this comment. Can we add some assertions to check if the API was called?
Contributor
There was a problem hiding this comment. I believe this should call |
||
| expect(mockedGetUserData).toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove
/programsagain?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier, we would navigate to this url. Now, we are only using it to store the "query" (backend api call) that we should make. I have refactored it a little. Hopefully it's clearer now. I also removed the
ClickEventstate, as it wasn't being used anywhere.