Skip to content

Conversation

@zawan-ila
Copy link
Contributor

This PR resolves some issues (introduced in 452) with the ProgramInspector :-

  1. If a network request fails for a search, running the same search won't retry the request, as the query state has not changed. We change the query from a string type to object type to circumvent this. This is also in line with the earlier behavior (from before 452)

  2. Remove existing search params whenever a new search is made. Not doing this causes older params to linger for a while until the new search updates the params (asynchronously). Depending on the network, this might take some time.

  3. Fix the error message when the getProgramEnrollments call "fails" (e.g when searching for a non-existent user).

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (99bcbb0) to head (429c225).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   85.91%   85.92%   +0.01%     
==========================================
  Files         185      185              
  Lines        3868     3872       +4     
  Branches      947      948       +1     
==========================================
+ Hits         3323     3327       +4     
  Misses        527      527              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zawan-ila zawan-ila merged commit c49da34 into master Apr 9, 2025
6 checks passed
@zawan-ila zawan-ila deleted the anawaz/fix-program-inspector branch April 9, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants