fix: some issues with program inspector #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some issues (introduced in 452) with the ProgramInspector :-
If a network request fails for a search, running the same search won't retry the request, as the query state has not changed. We change the query from a string type to object type to circumvent this. This is also in line with the earlier behavior (from before 452)
Remove existing search params whenever a new search is made. Not doing this causes older params to linger for a while until the new search updates the params (asynchronously). Depending on the network, this might take some time.
Fix the error message when the getProgramEnrollments call "fails" (e.g when searching for a non-existent user).