refactor: config and API #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbrandes
force-pushed
the
config-refactor
branch
2 times, most recently
from
7bf9999 to
f4c1dca
Compare
There is no need for a distinct ProjectSiteConfig; it is actually less confusing to accept that some config properties are indeed optional, and write code accordingly. The concept of "Project" is also a bit confusing, since the configuration is typed as "SiteConfig". So we're abandoning "Project" in favor of "Site". This renames most things accordingly. Continuing, rename SiteConfig's top-level `appId` to a more fitting `siteId`, leaving `appId` exclusively for the `App` type. In yet another rename, move the `custom` app config to what it's actually for: `standalone` mode. (Plus, "dev.legacy" is better described as "dev.standalone".) Also move test.site.config.tsx into the normal site.config.*.tsx pattern. There is no longer any reason for the distinction, as all site.config files are ok to be committed. Finally, adjust other webpack and site.config file names to a more conformant pattern.
First, rename the existing AppProvider to SiteProvider, in keeping with what the provided data refers to (SiteConfig). Second, add a new AppProvider that allows apps to use their AppConfigs from within an AppContext. In practice, this means they can useAppConfig() without having to refer to their own appId every time - which is the case with getAppConfig(appId).
Continuing with the theme of this refactor, rename APP_* to SITE_*. Also remove the unused APPS_CHANGED topic.
arbrandes
force-pushed
the
config-refactor
branch
from
f4c1dca to
05b6e27
Compare
This does a few things: * Renames APP_* events * Renames getConfig & company into getSiteConfig * Removes standalone mode: we don't foresee an intermediate step in MFE migration, anymore * This means the `appConfig` structure is not needed anymore, so remove it * ... which necessitated a refactor of the `App` type and associated functions
arbrandes
force-pushed
the
config-refactor
branch
from
05b6e27 to
55bbd12
Compare
arbrandes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large (and breaking) refactor that touches a bunch of things. See individual commits for details: