fix: remove unused jest-chain, babel-polyfill, axios-mock-adapter

[bradenmacdonald]

This repo has some unused dependencies.

Removing babel-polyfill is because (A) it's not needed, and (B) I'm trying to get rid of this warning seen when compiling any of our MFEs:

npm warn deprecated [email protected]: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

[openedx-webhooks]

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.56%. Comparing base (f47c1ed) to head (b5244ff).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   68.75%   72.56%   +3.81%     
==========================================
  Files          48       49       +1     
  Lines         432      492      +60     
  Branches       97      100       +3     
==========================================
+ Hits          297      357      +60     
  Misses        132      132              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[brian-smith-tcril]

LGTM!

Once the conflicts are resolved let's land this!

[bradenmacdonald]

Conflicts resolved!

Unrelated to this PR, the latest master is currently showing some dependency conflicts when running npm install:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/jest
npm warn   dev jest@"30.0.4" from the root project
npm warn
npm warn Could not resolve dependency:
npm warn peer jest@"^29.0.0" from [email protected]
npm warn node_modules/ts-jest
npm warn   peerOptional ts-jest@"27 || 28 || 29" from @formatjs/[email protected]
npm warn   node_modules/@formatjs/ts-transformer
npm warn   2 more (@openedx/frontend-build, @formatjs/ts-transformer)
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/jest
npm warn   peer jest@"^29.0.0" from [email protected]
npm warn   node_modules/ts-jest
npm warn     peerOptional ts-jest@"27 || 28 || 29" from @formatjs/[email protected]
npm warn     node_modules/@formatjs/ts-transformer
npm warn     2 more (@openedx/frontend-build, @formatjs/ts-transformer

I think it came from #620 . It can be fixed by removing node_modules and package-lock.json and then running npm install to re-generate it, but that also bumps many other package minor versions. I'm not sure if there's a simpler way to fix it.

[brian-smith-tcril]

It can be fixed by removing node_modules and package-lock.json and then running npm install to re-generate it, but that also bumps many other package minor versions. I'm not sure if there's a simpler way to fix it.

I think regenerating the package lock is perfectly reasonable (and preferable to manually editing it). I've run into similar issues before and resolved them by doing just that. It seems to happen sometimes after relying on renovate to update the package lock for a while. If you want to make a "regenerate package lock" PR I'll gladly approve/merge it.

[bradenmacdonald]

@brian-smith-tcril OK sure. I've done that here but I have had some issues so haven't been able to test it in an actual MFE: #622