fix: Improve Django admin preview readability in dark mode #101
Conversation
- Replaced inline styles with theme-aware admin CSS variables - Moved preview styling to static admin.css - Improved readability of preview and validation fields
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Pavilion4ik! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
- Fixed linter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 90.58% 90.74% +0.16%
==========================================
Files 47 48 +1
Lines 4310 4389 +79
Branches 271 271
==========================================
+ Hits 3904 3983 +79
Misses 317 317
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Pavilion4ik I'll be checking your PRs today |
Henrrypg
left a comment
Henrrypg
left a comment
There was a problem hiding this comment.
Just a couple of minor changes, It worked pretty fine in my local, great job @Pavilion4ik :)
| }), | ||
| ('Prompt Content', { | ||
| 'fields': ('body',), | ||
| 'description': 'The prompt template text - edit in the big textbox below.' |
There was a problem hiding this comment.
There are some comments here we don't to remove from now, please keep this one as before
| 'JSON5 Merge Patch (RFC 7386) to override base template values. ' | ||
| 'Supports comments (//, /* */), trailing commas, and unquoted keys. ' | ||
| 'Validation results appear in the "Preview & Validation" section below.' | ||
| 'JSON5 Merge Patch (RFC 7386). Supports comments, trailing commas, ' |
There was a problem hiding this comment.
Let's keep this one as before too
|
And please if can edit the cover letter, this is actually solving #84 instead of 91 |
- Restored the earlier version of comments
felipemontoya
left a comment
felipemontoya
left a comment
There was a problem hiding this comment.
Looks good. I'll merge now
github-project-automation
bot
moved this from Ready for Review
to Done
in Contributions
4 participants
This PR improves readability of Django admin preview fields when using dark mode.
What?
Why?
Issue: #84