-
Notifications
You must be signed in to change notification settings - Fork 5
feat: centralize orchestrator instantiation via BaseOrchestrator #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: centralize orchestrator instantiation via BaseOrchestrator #99
Conversation
- Introduce a factory method in BaseOrchestrator for consistent orchestrator creation - Refactor async tasks and workflow execution to use the centralized factory - Remove direct orchestrator imports and dynamic getattr usage - Ensure consistent orchestrator instantiation across the codebase - Add unit tests covering BaseOrchestrator behavior
|
Thanks for the pull request, @Pavilion4ik! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 90.58% 90.74% +0.16%
==========================================
Files 47 48 +1
Lines 4310 4389 +79
Branches 271 271
==========================================
+ Hits 3904 3983 +79
Misses 317 317
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Henrrypg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple but effective change, great job @Pavilion4ik, it worked fine in my side and i have no comments about the code changes, this change will also help us to move imports to toplevel
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This PR introduces a centralized approach for orchestrator creation to improve consistency and maintainability across workflow execution.
What:
Added a BaseOrchestrator factory method to resolve and instantiate orchestrators consistently. Refactored async tasks and workflow execution to use this central method, removing direct imports and dynamic getattr usage. Added unit tests for BaseOrchestrator covering correct instantiation and error handling.
Why:
To provide a single, reliable entry point for orchestrator creation, reduce duplication, prevent runtime errors from missing or misconfigured orchestrator classes, and improve maintainability and testability of workflow orchestration logic.
Issue: #87