Skip to content

Conversation

@Pavilion4ik
Copy link
Contributor

@Pavilion4ik Pavilion4ik commented Jan 12, 2026

This PR introduces a centralized approach for orchestrator creation to improve consistency and maintainability across workflow execution.

What:
Added a BaseOrchestrator factory method to resolve and instantiate orchestrators consistently. Refactored async tasks and workflow execution to use this central method, removing direct imports and dynamic getattr usage. Added unit tests for BaseOrchestrator covering correct instantiation and error handling.

Why:
To provide a single, reliable entry point for orchestrator creation, reduce duplication, prevent runtime errors from missing or misconfigured orchestrator classes, and improve maintainability and testability of workflow orchestration logic.

Issue: #87

- Introduce a factory method in BaseOrchestrator for consistent orchestrator creation
- Refactor async tasks and workflow execution to use the centralized factory
- Remove direct orchestrator imports and dynamic getattr usage
- Ensure consistent orchestrator instantiation across the codebase
- Add unit tests covering BaseOrchestrator behavior
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 12, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @Pavilion4ik!

This repository is currently maintained by @felipemontoya.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (5e02075) to head (d4f0472).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   90.58%   90.74%   +0.16%     
==========================================
  Files          47       48       +1     
  Lines        4310     4389      +79     
  Branches      271      271              
==========================================
+ Hits         3904     3983      +79     
  Misses        317      317              
  Partials       89       89              
Flag Coverage Δ
unittests 90.74% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jan 16, 2026
Copy link
Contributor

@Henrrypg Henrrypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but effective change, great job @Pavilion4ik, it worked fine in my side and i have no comments about the code changes, this change will also help us to move imports to toplevel

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@felipemontoya felipemontoya merged commit ebc2416 into openedx:main Jan 19, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants