Skip to content

refactor: remove deprecated sidebar toggles#37983

Merged
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril:remove-deprd-sidebar-toggles
Feb 9, 2026
Merged

refactor: remove deprecated sidebar toggles#37983
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril:remove-deprd-sidebar-toggles

Conversation

@brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Feb 5, 2026

Description

This PR removes the sidebar toggles that have been deprecated. See

The learning MFE no longer uses these, and site operators can instead now customize this behavior by utilizing Frontend Plugin Framework slots. See

Testing instructions

I verified the Learning MFE renders properly and does not produce any API errors, both locally and in the PR sandbox.

@brian-smith-tcril brian-smith-tcril force-pushed the remove-deprd-sidebar-toggles branch 5 times, most recently from 3c1249e to 94a3c57 Compare February 5, 2026 21:53
@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 6, 2026
@brian-smith-tcril brian-smith-tcril force-pushed the remove-deprd-sidebar-toggles branch from 94a3c57 to 69465d4 Compare February 6, 2026 16:44
@brian-smith-tcril brian-smith-tcril added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Feb 6, 2026
@brian-smith-tcril
Copy link
Contributor Author

I'm not sure what's happening with codecov

image

@brian-smith-tcril brian-smith-tcril force-pushed the remove-deprd-sidebar-toggles branch from 69465d4 to 0bb0849 Compare February 6, 2026 21:57
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I did not manually test but I did grep for any dangling references and found none.

Could you tidy up the PR description before merging?

"enable_navigation_sidebar": COURSEWARE_MICROFRONTEND_ENABLE_NAVIGATION_SIDEBAR.is_enabled(course_key),
"always_open_auxiliary_sidebar": COURSEWARE_MICROFRONTEND_ALWAYS_OPEN_AUXILIARY_SIDEBAR.is_enabled(course_key),
# Add completion tracking status for the sidebar use while a global place for switches is put in place
"enable_completion_tracking": ENABLE_COMPLETION_TRACKING_SWITCH.is_enabled()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pretty silly to have a REST API just for as single switch. even siller that it's parameterized on the course_id while the switch is site-wide. it would make a lot more sense if this were a waffle flag which got fed to the MFE Config API. (no changes needed, not a problem for now--just writing down my thoughts while I'm here.)

@brian-smith-tcril brian-smith-tcril merged commit fd15557 into openedx:master Feb 9, 2026
66 checks passed
Ardiea added a commit to mitodl/edx-platform that referenced this pull request Feb 19, 2026
The behavior of the MariaDB backend has changed behavior for UUIDField
from a `CharField(32)` to an actual `uuid` type. This is not converted
automatically, which results in all writes to the affected columns to
error with a message about the data being too long. This is because the
actual string being written is a UUID with the `-` included, resulting in
a 36 character value which can't be inserted into a 32 character column.

fix: renamed migration to 0016

Update cms/djangoapps/contentstore/migrations/0016_mariadb_uuid_conversion.py

Co-authored-by: David Ormsbee <dave@axim.org>

refactor: remove deprecated sidebar toggles (openedx#37983)

DEPR ticket: openedx/public-engineering#316

feat: Add Waffle flag for AuthZ for Course Authoring (openedx#37985)

build: Upgrade to `ora2==6.17.2` which removes loremipsum base dep (openedx#37991)

We hope this will fix an error where loremipsum is using pkg_resources,
which setuptools dropped support for as of v82 (released yesterday).

fix: Nits on styles of library icon [FC-0114] (openedx#37980)

- Fixes the issues described in openedx/frontend-app-authoring#2762 (comment):
    - Changed the background color for the library icon in the unit page.
    - Update punctuation for the library icon tooltip in the unit page.
    - Allows breaking the tooltip into multiple lines.

refactor: xblock api upstream info and course details api (openedx#37971)

- Returns top parent key instead of boolean in upstream info api
- Adds edited_on raw time in course outline api
- Adds has_changes to course details api

feat: Add enable_authz_course_authoring flag to course_waffle_flags endpoint (openedx#37990)

Discussion service to enable permission and access provider (openedx#37912)

* chore: discussion service to enable permission and access provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants