Skip to content

sync: release-23.x to next #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edx-requirements-bot merged 3 commits into from
Dec 18, 2025
Merged

sync: release-23.x to next #4049

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffe0e1b
chore: update browserslist DB (#4041)
edx-requirements-bot Dec 15, 2025
9d7ceef
fix: change `IconButton` base Props type to `ButtonHTMLAttributes` (#…
rpenido Dec 17, 2025
bde1c5b
chore(ci): update semantic release workflow to use OIDC (#4052)
brian-smith-tcril Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/IconButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { OverlayTrigger } from '../Overlay';
import Tooltip from '../Tooltip';
import Icon from '../Icon';

interface Props extends React.HTMLAttributes<HTMLButtonElement> {
interface Props extends React.ButtonHTMLAttributes<HTMLButtonElement> {
/** Component that renders the icon, currently defaults to `Icon` */
iconAs?: React.ComponentType<any>,
/** Additional CSS class[es] to apply to this button */
Expand Down
2 changes: 1 addition & 1 deletion src/IconButtonToggle/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import PropTypes from 'prop-types';
/**
*
* @param {object} args arguments
* @param {boolean} args.activeValue the current value of the active/selected iconButton.
* @param {string} args.activeValue the current value of the active/selected iconButton.
* if not provided, none of the iconButtons will initially be active
* @param {Function} args.onChange callback to call when toggle value changes.
* Receives value of the selected toggle button.
Expand Down
Loading