Skip to content

Conversation

@AhtishamShahid
Copy link
Contributor

@AhtishamShahid AhtishamShahid commented Nov 25, 2025

Added new patch to add email settings, this makes sure that NOTIFICATIONS_DEFAULT_FROM_EMAIL uses CONTACT_EMAIL if email value is not set

NOTIFICATIONS_DEFAULT_FROM_EMAIL = ENV_TOKENS.get("NOTIFICATIONS_DEFAULT_FROM_EMAIL", ENV_TOKENS["CONTACT_EMAIL"])

This resolves this issue
#27

FYI @bmtcril @saraburns1

@AhtishamShahid AhtishamShahid marked this pull request as draft November 25, 2025 08:55
@AhtishamShahid AhtishamShahid force-pushed the ahtisham/added_email_config branch 2 times, most recently from 2487361 to 09b17a3 Compare November 25, 2025 09:40
@AhtishamShahid AhtishamShahid marked this pull request as ready for review November 25, 2025 09:42
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AhtishamShahid Thank you for this PR I think we should allow a way for people using tutor-contrib-notification to set the value for NOTIFICATIONS_DEFAULT_FROM_EMAIL, We need to add this in plugin.py and assign a default value to this.

And then use the value from here to set this in the file, also instead of setting it in two different places you can set it in openedx-common-settings and this should apply everywhere.

@AhtishamShahid
Copy link
Contributor Author

@AhtishamShahid Thank you for this PR I think we should allow a way for people using tutor-contrib-notification to set the value for NOTIFICATIONS_DEFAULT_FROM_EMAIL, We need to add this in plugin.py and assign a default value to this.

And then use the value from here to set this in the file, also instead of setting it in two different places you can set it in openedx-common-settings and this should apply everywhere.

Hi , I have updated the PR and tested it with. tutor config save --set . Now users can update the email if needed.

Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

✅ I tested this: on tutor devstack, the changes are made in the config and settings files
✅ I read through the code
❌ I checked for accessibility issues
❌ Includes documentation

@farhaanbukhsh
Copy link
Member

@AhtishamShahid A small nit is to add the same info in the readme file as well.

@AhtishamShahid AhtishamShahid added ulmo Released in Ulmo core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 26, 2025
feat: updated docs for changes
@AhtishamShahid AhtishamShahid force-pushed the ahtisham/added_email_config branch from 2db42bd to a5c7f7d Compare November 26, 2025 13:05
@farhaanbukhsh farhaanbukhsh merged commit ced04a4 into openedx:main Nov 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). ulmo Released in Ulmo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants