Skip to content

Conversation

@samuelallan72
Copy link

Description

It was pinned in constraints, but this was not being honoured. I suspect it's because cssselect is not explicitly installed in the base requirements? Anyway, adding it here fixes it, successfully installing cssselect==1.2. Tested with python 3.11.

Supporting information

Private-ref: https://tasks.opencraft.com/browse/BB-10445

Testing instructions

  • switch to the master branch, install in a virtual environment, and verify that the incorrect version of cssselect is installed (v1.3)
  • switch to this branch, install in a virtual environment, and verify that cssselect==1.2 is successfully installed.

@openedx-webhooks
Copy link

Thanks for the pull request, @samuelallan72!

This repository is currently maintained by @Agrendalath.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 8, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 8, 2026
It was pinned in constraints, but this was not being honoured.
I suspect it's because cssselect is not explicitly installed in the base requirements?
Anyway, adding it here fixes it, successfully installing cssselect==1.2.
Tested with python 3.11.

Private-ref: https://tasks.opencraft.com/browse/BB-10445
@samuelallan72 samuelallan72 force-pushed the samuel/fix-cssselect-pin branch from 3257b4f to d41a962 Compare January 8, 2026 03:25
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jan 8, 2026
@Agrendalath
Copy link
Member

@samuelallan72, this is no longer needed, as we are removing this dependency in #228.

@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Jan 11, 2026
@samuelallan72 samuelallan72 deleted the samuel/fix-cssselect-pin branch January 11, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants