Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Conversation

q9f
Copy link
Member

@q9f q9f commented Apr 11, 2020

  • moves *_test specs into test-spec subdirectory
  • checks foundation and classic against all eips in:
    • frontier
    • homestead
    • byzantium
    • constantinople
    • st_peters
    • istanbul

currently fails for classic on istanbul, waiting for #11598

Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane. @adria0 Do you see any issues with this?

@dvdplm dvdplm added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Apr 11, 2020
@q9f
Copy link
Member Author

q9f commented Apr 11, 2020

ok, after #11598, the CI should pass now.

Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Apr 14, 2020
@q9f q9f closed this Apr 14, 2020
@q9f q9f deleted the q9-valid-chainspecs branch April 14, 2020 22:09
@q9f q9f restored the q9-valid-chainspecs branch April 15, 2020 09:21
@q9f q9f reopened this Apr 15, 2020
@niklasad1 niklasad1 merged commit 2a3b321 into openethereum:master Apr 15, 2020
@q9f q9f deleted the q9-valid-chainspecs branch April 15, 2020 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants