Support streaming logs for remote builds. - #1007
Merged
Merged
Conversation
welteki
force-pushed
the
builder
branch
3 times, most recently
from
June 17, 2025 20:27
c0f2273 to
a9c9fb1
Compare
Member
|
Can you show that |
alexellis
reviewed
Jun 18, 2025
Switch to the Go SDK for remote builds with the up and publish commands. Both commands now stream build logs if the Function Builder API supports it. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
A version of the creaetBuildContext function has been included in the Go SDK. Srart using the builder.CreateBuildContext function from the Go SDK to reduce code duplication. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Additional packages defined through build options were ignored when using a remote builder. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Member
|
|
Only keep scheme and host when initialzing the builder client. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for streaming build logs when building function using the OpenFaaS Function Builder API
Switch to the "github.com/openfaas/go-sdk/builder" package for building functions.
Use the builder.FunctionBuilder to invoke the Function Builder API for remote builds.
Both the
faas-cli upandfaas-cli publishcommand stream build logs to sdout if the Function Builder API supports it.Switch to using the
builder.CreateBuildeContextandbuilder.MakeTarfunctions from the Go SDK instead of their local variants.Motivation and Context
Provide real time feedback on build progress for remote builds.
How Has This Been Tested?
Verified both the
faas-cli upandfaas-cli publishcommand work as expected when using the remoter builder. Verified build logs are streamed in real time when using the latest version of the function builder.faas-cli up --remote-builder http://127.0.0.1:8081 \ --payload-secret $HOME/.openfaas/payload.txtfaas-cli publish --remote-builder http://127.0.0.1:8081 \ --payload-secret $HOME/.openfaas/payload.txtVerified both the
faas-cli upandfaas-cli publishcommand still work with older versions (<0.4.3) of the function builder that do not support streaming build logs.Types of changes
Checklist:
git commit -s