Use same header format as curl for invoke command#1009
Merged
alexellis merged 1 commit intoopenfaas:masterfrom Jul 16, 2025
Merged
Use same header format as curl for invoke command#1009alexellis merged 1 commit intoopenfaas:masterfrom
alexellis merged 1 commit intoopenfaas:masterfrom
Conversation
Change the header flag to accept key value pairs separated by a colon. e.g. "key: value". The previous format is marked as deprecated but still supported. A warning is printed when it is used. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
rgee0
reviewed
Jun 27, 2025
| if value == "" { | ||
| return httpHeader, fmt.Errorf("the --header or -H flag must take the form of key=value (empty value given)") | ||
| // Fallback to deprecated key=value format | ||
| parts = strings.SplitN(header, "=", 2) |
Contributor
There was a problem hiding this comment.
Could we pre-process header to replace = with : when a colon isn't present? Then we'd only need a header processing once.
We could also show the warning from the pre-processing step if a replace took place, and wrap a test around the pre-processor.
Alternatively, the header processing could be extracted as a function:
func processHeader(header, separator)(k, v){
...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the header flag to accept key value pairs separated by a colon. e.g. "key: value".
The previous format is marked as deprecated but still supported. A warning is printed when it is used.
Fix an issues where the 'Content-Type' header was being overridden by the default value of the
--content-typeflag when the flag is not set explicitly.e.g. when running
faas-cli invoke -H "Content-Type=application/tar"the content type would be overridden with the default valuetext/plain.Motivation and Context
Align the format more closely with
curlto make the invoke command as intuitive and familiar as possible.How Has This Been Tested?
Changes are covered by unit test.
Verify headers can be set using the new format:
Verify the deprecated format is still accepted and prints a warning:
Types of changes
Checklist:
git commit -s