Nullify the rDescr pointer after deleting the heap-allocated FFaResultDescription object#43
Merged
Nullify the rDescr pointer after deleting the heap-allocated FFaResultDescription object#43
Conversation
deleting the heap-allocated FFaResultDescription object. This is done in the new method FFpCurve::resizeReader().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes openfedem/fedem-gui#125 when consumed by that repository.
The problem occurred when a beam diagram curve was plotted the second time. The heap-allocated
FFaDescriptionobjects are the reallocated but the pointers were not nullified after the deallocation. They were therefore not allocated again and instead the heap-memory that was deallocated was referenced again creating all kind of problems.