Dependencies update + ESLint v9 #1064

Siddhant-K-code · 2025-07-12T07:04:47Z

ESLint v9 migration (addresses @ewanharris's feedback)
All dependency updates

Summary by CodeRabbit

Chores
- Updated multiple dependencies to their latest versions for improved stability and compatibility.
- Added a new development dependency to enhance environment variable management.
- Migrated ESLint configuration to a new format for better maintainability and compatibility with modern tooling.

- Update configuration documentation to reference v1.8.15 - Update resolveNodeBreadthLimit default value from 100 to 10 - Update dependencies to latest versions

- Update all dependencies to latest versions - Migrate from .eslintrc.json to eslint.config.js for ESLint v9 compatibility - Add globals dependency for proper ESLint configuration - Fix CI lint step failures This addresses reviewer feedback about ESLint v9 migration requirements.

coderabbitai · 2025-07-12T07:04:54Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes replace the existing .eslintrc.json ESLint configuration with a new, modular eslint.config.js that provides multiple scoped configurations and disables stylistic rules to align with Prettier. Dependency versions in package.json are updated, and a new globals dev dependency is added. No application code or exports are modified.

Changes

File(s)	Change Summary
.eslintrc.json	Removed legacy ESLint configuration JSON file.
eslint.config.js	Added modular ESLint config with multiple scoped overrides, Prettier compatibility, and plugins.
package.json	Updated Docusaurus, OpenFGA, sanitize-html, swagger-ui-react, ESLint, and TypeScript plugin versions; added `globals` dev dependency.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant ESLint
    participant eslint.config.js

    Developer->>ESLint: Run lint command
    ESLint->>eslint.config.js: Load configuration
    eslint.config.js-->>ESLint: Provide scoped and merged rules
    ESLint->>Developer: Report lint results based on new config

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

This branch should only contain dependency updates and ESLint changes, not documentation changes.

rhamzeh · 2025-07-14T13:03:24Z

The type check here is no longer passing

socket-security · 2025-07-15T10:10:08Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@types/react@18.3.5 ⏵ 18.3.9	⁺¹	⁺¹
globals@13.24.0 ⏵ 16.3.0		⁺¹
eslint@8.57.0 ⏵ 9.29.0	⁺¹		⁺²

View full report

socket-security · 2025-07-15T10:10:10Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		`[email protected]` has a License Policy Violation. License: CC-BY-4.0 (npm metadata) License: CC-BY-4.0 (package/LICENSE) License: CC-BY-4.0 (package/package.json) From: package-lock.json → `npm/@docusaurus/[email protected]` → `npm/@docusaurus/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is a license policy violation? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

eslint.config.js (1)
67-134: Consider using eslint-config-prettier instead of manually disabling rules.

The extensive manual disabling of Prettier-conflicting rules could be simplified by using the eslint-config-prettier package, which is already in your dependencies.
-  {
-    rules: {
-      // Prettier config to disable conflicting rules
-      'array-bracket-newline': 'off',
-      'array-bracket-spacing': 'off',
-      // ... (many more rules)
-    }
-  }
+  require('eslint-config-prettier')
This would make the configuration more maintainable and ensure all Prettier conflicts are properly handled.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60a9ac3 and 78d9fe3.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

.eslintrc.json (0 hunks)
eslint.config.js (1 hunks)
package.json (2 hunks)

💤 Files with no reviewable changes (1)

.eslintrc.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: deploy-preview
GitHub Check: Test deployment

🔇 Additional comments (3)

package.json (2)

28-31: LGTM: Dependency updates look reasonable.

The Docusaurus, TypeScript ESLint, and other dependency updates appear to be standard patch/minor version updates that should maintain compatibility.

Also applies to: 47-47, 53-57

34-34: No breaking changes in @openfga/sdk v0.9.0

The official changelog for v0.9.0 only adds a new “client assertion for client credentials authentication” feature (#228) and does not list any BREAKING CHANGES. The last breaking changes occurred in v0.8.0. You can safely keep the "@openfga/sdk": "^0.9.0" update.

✅ OpenFGA SDK update approved.

eslint.config.js (1)

1-6: LGTM: Import structure follows ESLint v9 flat config pattern.

The imports are correctly structured for the new ESLint v9 flat configuration format.

eslint.config.js

Siddhant-K-code · 2025-07-15T10:17:04Z

@rhamzeh, it's working now. One lint check is failing, which is similar to #1063 (comment)

rhamzeh · 2025-09-04T15:28:07Z

@Siddhant-K-code would you mind running npm i to resolve the issues? We can merge then

…pendency

Siddhant-K-code · 2025-10-11T17:13:19Z

@rhamzeh, sorry i've missed the notification. We are good to go now

Siddhant-K-code added 2 commits June 16, 2025 07:23

docs: update OpenFGA configuration for v1.8.15

eb01fe0

- Update configuration documentation to reference v1.8.15 - Update resolveNodeBreadthLimit default value from 100 to 10 - Update dependencies to latest versions

Siddhant-K-code requested review from a team as code owners July 12, 2025 07:04

fix: revert configuration.mdx to match main branch

3b21fc9

This branch should only contain dependency updates and ESLint changes, not documentation changes.

Siddhant-K-code mentioned this pull request Jul 12, 2025

docs: update OpenFGA configuration for v1.8.16 & CI automation #1054

Closed

2 tasks

Merge branch 'main' into chore/update-dependencies-eslint-v9

78d9fe3

fix types

11f6931

coderabbitai bot reviewed Jul 15, 2025

View reviewed changes

eslint.config.js Show resolved Hide resolved

eslint.config.js Show resolved Hide resolved

Merge branch 'main' into chore/update-dependencies-eslint-v9

cf4dd69

rhamzeh and others added 3 commits September 4, 2025 12:44

Merge branch 'main' into chore/update-dependencies-eslint-v9

fcd691d

Merge branch 'main' into chore/update-dependencies-eslint-v9

7ef6b20

chore(deps): update form-data to version 4.0.4 and add hasown as a de…

acd3a2c

…pendency

rhamzeh approved these changes Oct 11, 2025

View reviewed changes

rhamzeh merged commit 01f88a8 into openfga:main Oct 11, 2025
11 of 14 checks passed

Siddhant-K-code deleted the chore/update-dependencies-eslint-v9 branch October 12, 2025 04:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dependencies update + ESLint v9 #1064

Dependencies update + ESLint v9 #1064

Uh oh!

Siddhant-K-code commented Jul 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 12, 2025 •

edited

Loading

Review skipped

Uh oh!

rhamzeh commented Jul 14, 2025

Uh oh!

socket-security bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Siddhant-K-code commented Jul 15, 2025

Uh oh!

rhamzeh commented Sep 4, 2025

Uh oh!

Siddhant-K-code commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dependencies update + ESLint v9 #1064

Dependencies update + ESLint v9 #1064

Uh oh!

Conversation

Siddhant-K-code commented Jul 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

rhamzeh commented Jul 14, 2025

Uh oh!

socket-security bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Siddhant-K-code commented Jul 15, 2025

Uh oh!

rhamzeh commented Sep 4, 2025

Uh oh!

Siddhant-K-code commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Siddhant-K-code commented Jul 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 12, 2025 •

edited

Loading

socket-security bot commented Jul 15, 2025 •

edited

Loading

socket-security bot commented Jul 15, 2025 •

edited

Loading