Skip to content

Fix static build linking on windows#1903

Merged
joshtynjala merged 2 commits intoopenfl:developfrom
tobil4sk:fix/windows-static-build
Feb 10, 2025
Merged

Fix static build linking on windows#1903
joshtynjala merged 2 commits intoopenfl:developfrom
tobil4sk:fix/windows-static-build

Conversation

@tobil4sk
Copy link
Copy Markdown
Member

There was a .lib file missing that's required for linking mbedtls, see: openfl/openfl#2603

This also fixes a change from #1529. The original PR mentions that debug causes the console subsystem, however, actually it's specifically the hxcpp-debugger that causes it. This meant that if running a debug build without the debugger, the following linker error would occur:

LIBCMT.lib(exe_winmain.obj) : error LNK2019: unresolved external symbol WinMain referenced in function "int __cdecl __scrt_common_main_seh(void)" (?__scrt_common_main_seh@@YAHXZ)
Main-debug.exe : fatal error LNK1120: 1 unresolved externals

@tobil4sk tobil4sk changed the title Fix static build on windows Fix static build linking on windows Feb 10, 2025
@joshtynjala joshtynjala merged commit d1db9e8 into openfl:develop Feb 10, 2025
30 checks passed
@tobil4sk tobil4sk deleted the fix/windows-static-build branch February 10, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants