feat(prices): add management command to fix missing currency#1124
Open
Kinjal0007 wants to merge 2 commits intoopenfoodfacts:mainfrom
Open
feat(prices): add management command to fix missing currency#1124Kinjal0007 wants to merge 2 commits intoopenfoodfacts:mainfrom
Kinjal0007 wants to merge 2 commits intoopenfoodfacts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some
Priceentries have nullcurrency, which causes issues for clients like Smoothie that assume currency is always present.Fix
This PR adds a non-breaking management command
fix_missing_price_currency:--write, fills currency using:proof.currencyif availablelocation.osm_address_country_codeNotes
Usage