feat: use openfoodfacts-ruby gem as generic codebase#58
Closed
feat: use openfoodfacts-ruby gem as generic codebase#58
Conversation
Co-authored-by: nicolasleger <570901+nicolasleger@users.noreply.github.com>
Co-authored-by: nicolasleger <570901+nicolasleger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] feat: use openfoodfacts-ruby gem as generic codebase
feat: use openfoodfacts-ruby gem as generic codebase
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the requested feature to use the
openfoodfacts-rubygem as the generic codebase foropenbeautyfacts-ruby, significantly reducing code duplication while maintaining full backward compatibility.Changes Made
Core Implementation
openfoodfacts ~> 0.9.0as runtime dependency to leverage the mature openfoodfacts codebaseOpenbeautyfactsnamespace that inherit fromOpenfoodfactsclasses but default to theopenbeautyfacts.orgdomainDomain Integration
openfoodfacts.orgwithopenbeautyfacts.orgin all API callsapi/v0/produit/URL format instead of adopting openfoodfacts'api/v2/product/formatOpenbeautyfacts.product_url()andOpenbeautyfacts.locale_from_link()Backward Compatibility
Allergen,Ingredient,PeriodAfterOpening)Openbeautyfacts::Productobjects are instances ofOpenfoodfacts::ProductExample Usage
The API remains exactly the same:
Benefits
Testing
OpenbeautyfactsnamespaceThis implementation successfully fulfills the requirements while maintaining full backward compatibility and significantly reducing the maintenance burden.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fr.openbeautyfacts.org/usr/bin/ruby3.2 -w -Ilib:lib:test /home/REDACTED/.bundle/ruby/3.2.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb test/test_openbeautyfacts.rb(dns block)world.openbeautyfacts.org/usr/bin/ruby3.2 -w -Ilib:lib:test /home/REDACTED/.bundle/ruby/3.2.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb test/test_openbeautyfacts.rb(dns block)world.openfoodfacts.org/usr/bin/ruby3.2 -w -Ilib:lib:test /home/REDACTED/.bundle/ruby/3.2.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb test/test_openbeautyfacts.rb(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.