fix: imageNames sorting to preserve descending timestamp order#5461
Open
gabbyemsden wants to merge 1 commit intoopenfoodfacts:developfrom
Open
fix: imageNames sorting to preserve descending timestamp order#5461gabbyemsden wants to merge 1 commit intoopenfoodfacts:developfrom
gabbyemsden wants to merge 1 commit intoopenfoodfacts:developfrom
Conversation
- Add explicit sortedByDescending in ViewModel to ensure images are returned sorted by upload timestamp (newest first) - Ensures sort order is preserved through Flow transformations - Fixes openfoodfacts#5013
|
gabbyemsden
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5013 - Image names sorting by upload time
This PR fixes the failing test in
ProductPhotosViewModelTestwhereimageNamesshould return image names sorted by upload timestamp in descending order (newest first).Changes Made
.sortedByDescending { it.timestamp }inProductPhotosViewModelto ensure images are returned in the correct orderImageNameParser.extractImageNames()already returns sorted data, but this ensures the order is maintained through the reactive Flow pipelineTesting
ProductPhotosViewModelTest > Given product api returns product images > When imageNames is called > it should return image names sorted by uploaded timeRelated Issues
Fixes #5013
Notes
This is my contribution as part of EECS 481 (Software Engineering) at University of Michigan.