fix: making changes in importer.py and annotate.py#1518
Closed
prasanna7codes wants to merge 1 commit intoopenfoodfacts:mainfrom
prasanna7codes:prasanna/971
Closed
fix: making changes in importer.py and annotate.py#1518prasanna7codes wants to merge 1 commit intoopenfoodfacts:mainfrom prasanna7codes:prasanna/971
prasanna7codes wants to merge 1 commit intoopenfoodfacts:mainfrom
prasanna7codes:prasanna/971
Conversation
Member
|
@prasanna7codes thanks a lot for this contribution. Sorry because it's a long time since I worked on robotoff, and main robotoff contributor is AFK for some time ! That said I'm not sure the way you wrote it is not the way robotoff work. The importer should generate an insight, which if auto applied, will generate the annotation. Please take a look how it works for the others. Also a test would be appreciated if you can. You can come on the slack.openfoodfacts.org in #robotoff to discuss it if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
-Implemented the Image Orientation Auto-Rotation feature.
ImageOrientationImporter class parses the prediction.data JSON to determine the required rotation based on word orientation.
-ImageOrientationAnnotator class rotates the image if needed based on the rotation angle from the importer.
Integrated logic to check if the predicted orientation is not "up" and confidence is >= 95% before rotating.
Screenshot
Fixes bug(s)
#Fixed issue where images were not rotated automatically if the predicted orientation was incorrect.
Part of