feat: implement image orientation annotation and importing logic#1549
Closed
areebahmeddd wants to merge 12 commits intoopenfoodfacts:mainfrom
areebahmeddd:issues/971/image-rotate
Closed
feat: implement image orientation annotation and importing logic#1549areebahmeddd wants to merge 12 commits intoopenfoodfacts:mainfrom areebahmeddd:issues/971/image-rotate
areebahmeddd wants to merge 12 commits intoopenfoodfacts:mainfrom
areebahmeddd:issues/971/image-rotate
Conversation
github-project-automation
bot
added this to 🤖 Artificial Intelligence @ Open Food Facts
github-project-automation
bot
moved this to To triage
in 🤖 Artificial Intelligence @ Open Food Facts
areebahmeddd
changed the title
alexgarel
reviewed
Apr 22, 2025
Member
alexgarel
left a comment
alexgarel
left a comment
There was a problem hiding this comment.
@areebahmeddd good work, you are on the right track ! Please see my comments.
Member
|
@areebahmeddd, see #971 (comment) Sorry for I misguide you to a fix that was not the right one. |
Member
Author
|
Ah i see! No problem 😄 Currently out of station for a while, will address the updated requirements over the weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageOrientationImporterto generate insights for images requiring rotation (i.e., when orientation is not "up" and confidence is ≥95%)ImageOrientationAnnotatorto process approved insights by applying the appropriate rotation to images.Done:
-Unit tests all green.
Todo:
-Investigate integration test failures (database schema issues??)
Part of
Issue #971