Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
mattwthompson
approved these changes
Feb 10, 2026
Member
mattwthompson
left a comment
mattwthompson
left a comment
There was a problem hiding this comment.
Thanks for fixing this - I see SetupTools 82 in logs so this is likely to be the fix we need
This reverts commit 65fc593.
lilyminium
force-pushed
the
remove-smirnoff99frosst
branch
from
543ebc1 to
9513f17
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
Thanks @mattwthompson! In that case I also added a reversion of the pin to setuptools==81, if you don't mind -- I think that'll save us future maintenance down the line. |
Member
|
I think that's the right move - feel free to merge this as-is (or I'll press the button later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the PR's purpose here.
Removes SMIRNOFF99Frosst -- fixes #729, hopefully