Move get_charge_array to ElectrostaticsCollection
#1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
changed the title
get_charge_array to base classget_charge_array to ElectrostaticsCollection
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 73 73
Lines 6327 6327
=======================================
Hits 5939 5939
Misses 388 388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-wags
approved these changes
Jan 7, 2026
Member
j-wags
left a comment
j-wags
left a comment
There was a problem hiding this comment.
LGTM, could be worth adding to releasenotes since everything that inherits from ElectrostaticsCollection (eg FoyerElectrostaticsHandler, BasicElectrostaticsCollection) just gained a method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1393
This won't quite fix #1394 but it seems to work as a standalone change
Checklist