Skip to content

Update torsion scripts consistent with yammbs metrics updates#98

Open
fjclark wants to merge 6 commits intomainfrom
update-torsion-scripts
Open

Update torsion scripts consistent with yammbs metrics updates#98
fjclark wants to merge 6 commits intomainfrom
update-torsion-scripts

Conversation

@fjclark
Copy link
Collaborator

@fjclark fjclark commented Jan 16, 2026

This updates the torsion script and automation consistent with openforcefield/yammbs#191.

I've tested locally by setting up a dummy submission dir and config, manually running torsions.py, and checking the output. However, I wasn't sure best how to test/ add tests for the changes to the GitHub automation. Please let me know if you have any suggestions. Thanks!

@mattwthompson
Copy link
Member

Unfortunately (#87) the best I have come up with is making a minimally-small dataset and firing it off as a submission in a PR. You can see some examples in recent messy PRs like #90

There is one floating around for optimizations but not yet one for torsions -- making one with a single torsion drive would probably be sufficient here and finish in decent runtime (1-2 minutes?).

However if you don't have much time (or desire - would not be offended) to muck around in that I am happy to take over from here

@fjclark
Copy link
Collaborator Author

fjclark commented Jan 16, 2026

Thanks! I may get some time towards the end of next week, but please go ahead and take over if you have time before then.

@mattwthompson
Copy link
Member

/run-torsion-benchmark torsion-dev/tmp.yaml "test torsion updates"

@mattwthompson
Copy link
Member

/run-torsion-benchmarks torsion-dev/tmp.yaml "test torsion updates"

@github-actions
Copy link

A workflow has been dispatched to run the benchmarks for this PR.

  • Run ID: 21182898852
  • Triggering actor: github-actions[bot]
  • Target branch: update-torsion-scripts

@github-actions
Copy link

A workflow dispatched to run torsion benchmarks for this PR has just finished.

@mattwthompson
Copy link
Member

/run-torsion-benchmarks torsion-dev/tmp.yaml devtools/env.yaml "test torsion updates"

@github-actions
Copy link

A workflow has been dispatched to run the benchmarks for this PR.

  • Run ID: 21183352694
  • Triggering actor: github-actions[bot]
  • Target branch: update-torsion-scripts

@github-actions
Copy link

A workflow dispatched to run torsion benchmarks for this PR has just finished.

@mattwthompson
Copy link
Member

/run-torsion-benchmarks torsion-dev/run.yaml devtools/env.yaml "test torsion updates"

@github-actions
Copy link

A workflow has been dispatched to run the benchmarks for this PR.

  • Run ID: 21186480978
  • Triggering actor: github-actions[bot]
  • Target branch: update-torsion-scripts

@github-actions
Copy link

A workflow dispatched to run torsion benchmarks for this PR has just finished.

@mattwthompson
Copy link
Member

/run-torsion-benchmarks torsion-dev/run.yaml devtools/env.yaml "test torsion updates"

@github-actions
Copy link

A workflow has been dispatched to run the benchmarks for this PR.

  • Run ID: 21187526543
  • Triggering actor: github-actions[bot]
  • Target branch: update-torsion-scripts

@github-actions
Copy link

A workflow dispatched to run torsion benchmarks for this PR has just finished.

@mattwthompson
Copy link
Member

/run-torsion-benchmarks torsion-dev/run.yaml devtools/env.yaml "test torsion updates"

@github-actions
Copy link

A workflow has been dispatched to run the benchmarks for this PR.

  • Run ID: 21188725706
  • Triggering actor: github-actions[bot]
  • Target branch: update-torsion-scripts

@github-actions
Copy link

A workflow dispatched to run torsion benchmarks for this PR has just finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants