-
Notifications
You must be signed in to change notification settings - Fork 0
Update 2025 06 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update 2025 06 #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the RStudio infrastructure by modernizing Docker and AWS CLI installations and upgrading the RStudio Docker image base version. The changes improve installation reliability by using official Docker repositories and AWS CLI v2, while reorganizing R package dependencies for better maintainability.
Changes:
- Updated Docker installation in EC2 UserData script to use official Docker CE packages from Docker's repository instead of Ubuntu's default packages
- Upgraded AWS CLI installation to use AWS CLI v2 with proper installation method
- Updated RStudio base image from
rocker/rstudio:latesttorocker/rstudio:4.5.1for version pinning - Reorganized and consolidated R package installations in Dockerfile, adding new packages (stringr, srvyr) and cleaning up duplicates
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| RStudioPoolService/src/domain/Instance/model.js | Modernizes EC2 instance setup script with official Docker CE installation, AWS CLI v2, improved Docker configuration, and adds container restart policy |
| RStudioDocker/Dockerfile | Pins base image version, reorganizes system and R package installations for better readability, adds new R packages, and includes cleanup commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| libgdal-dev \ | ||
| libfontconfig1-dev \ | ||
| libgit2-dev \ | ||
| libglu1-mesa-dev \ |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The libglu1-mesa-dev package is installed twice - once on line 12 and again on line 23. Remove the duplicate installation to keep the Dockerfile clean and efficient.
| libglu1-mesa-dev \ |
| # add current user to "docker" group (to allow running docker without sudo) | ||
| sudo usermod -aG docker $USER | ||
| newgrp docker |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newgrp docker command won't work as expected in a UserData script because it starts a new shell session and doesn't affect the parent shell. In a non-interactive script context like UserData, this command will have no effect on subsequent commands. The group membership will only take effect after the user logs out and back in.
Since line 95 runs the docker command with sudo anyway, the group membership change isn't critical for this script. However, if the intention is to run docker commands without sudo, consider removing the newgrp docker line (as it's ineffective) and either keep using sudo for docker commands, or use sg docker -c "command" to run specific commands with the docker group.
| # add current user to "docker" group (to allow running docker without sudo) | |
| sudo usermod -aG docker $USER | |
| newgrp docker | |
| # add current user to "docker" group (to allow running docker without sudo in future logins) | |
| sudo usermod -aG docker $USER |
No description provided.