Skip to content

Conversation

@dfguerrerom
Copy link
Collaborator

  • Update pygaul>=0.4.2 for FAO GAUL 2024 dataset support

    • Changed AdmItems -> Items, AdmNames -> Names
    • Changed column names: ADM0_CODE -> gaul0_code, ADM0_NAME -> gaul0_name
    • iso3_code now included directly in GAUL 2024
    • Update GAUL asset path for GEE tests
    • Update tests with new GAUL 2024 codes (e.g., Holy See: 110 -> 307)
  • Update localtileserver>=0.10.1 and remove rio-tiler<7 pin

- Update pygaul>=0.4.2 for FAO GAUL 2024 dataset support
  - Changed AdmItems -> Items, AdmNames -> Names
  - Changed column names: ADM0_CODE -> gaul0_code, ADM0_NAME -> gaul0_name
  - iso3_code now included directly in GAUL 2024
  - Update GAUL asset path for GEE tests
  - Update tests with new GAUL 2024 codes (e.g., Holy See: 110 -> 307)

- Update localtileserver>=0.10.1 and remove rio-tiler<7 pin
  - Closes #952 (rio-tiler v7 compatibility)
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GAUL/tileserver dependencies and adjusts AOI logic/tests to work with GAUL 2024 schemas and rio-tiler v7-compatible localtileserver.

Changes:

  • Bump pygaul to >=0.4.2 and update AOI codepaths from AdmItems/AdmNames to Items/Names, plus GAUL 2024 column handling (gaul0_code, iso3_code, etc.).
  • Update AOI-related tests/fixtures to use GAUL 2024 codes (e.g., Holy See 307) and updated bounds/columns snapshots.
  • Bump localtileserver to >=0.10.1 and remove the rio-tiler<7 pin.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sepal_ui/aoi/aoi_model.py Switch GAUL access to pygaul.Items, use GAUL 2024 properties (iso3_code, gaul0_code, *_name), update ISO fallback logic.
sepal_ui/aoi/aoi_view.py Update admin-name lookup to pygaul.Names for GAUL 2024 compatibility.
tests/test_aoi/test_AoiView.py Adjust GAUL test expectations (Holy See code, first item code).
tests/test_aoi/test_AoiModel.py Update admin code, GAUL asset path, column names/types, and fixture wording.
tests/test_aoi/test_AoiModel/test_get_columns.yml Refresh expected GAUL 2024 column snapshot.
tests/test_aoi/test_AoiModel/test_total_bounds.yml Refresh expected bounds snapshot.
pyproject.toml Bump localtileserver, bump pygaul, remove rio-tiler<7 pin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Add isinstance check for iso to prevent AttributeError when iso3_code is None
- Update AdminField docstring from GAUL 2015 to GAUL 2024
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.81%. Comparing base (772aabd) to head (784928d).

Files with missing lines Patch % Lines
sepal_ui/aoi/aoi_model.py 60.00% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   79.79%   79.81%   +0.01%     
==========================================
  Files          55       55              
  Lines        5518     5523       +5     
==========================================
+ Hits         4403     4408       +5     
  Misses       1115     1115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dfguerrerom dfguerrerom merged commit ae73561 into main Jan 31, 2026
8 checks passed
@dfguerrerom dfguerrerom deleted the pygaul branch January 31, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unpin rio-tile

2 participants