-
Notifications
You must be signed in to change notification settings - Fork 3
fix(deps): update pygaul and localtileserver for compatibility #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update pygaul>=0.4.2 for FAO GAUL 2024 dataset support - Changed AdmItems -> Items, AdmNames -> Names - Changed column names: ADM0_CODE -> gaul0_code, ADM0_NAME -> gaul0_name - iso3_code now included directly in GAUL 2024 - Update GAUL asset path for GEE tests - Update tests with new GAUL 2024 codes (e.g., Holy See: 110 -> 307) - Update localtileserver>=0.10.1 and remove rio-tiler<7 pin - Closes #952 (rio-tiler v7 compatibility)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates GAUL/tileserver dependencies and adjusts AOI logic/tests to work with GAUL 2024 schemas and rio-tiler v7-compatible localtileserver.
Changes:
- Bump
pygaulto>=0.4.2and update AOI codepaths fromAdmItems/AdmNamestoItems/Names, plus GAUL 2024 column handling (gaul0_code,iso3_code, etc.). - Update AOI-related tests/fixtures to use GAUL 2024 codes (e.g., Holy See 307) and updated bounds/columns snapshots.
- Bump
localtileserverto>=0.10.1and remove therio-tiler<7pin.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
sepal_ui/aoi/aoi_model.py |
Switch GAUL access to pygaul.Items, use GAUL 2024 properties (iso3_code, gaul0_code, *_name), update ISO fallback logic. |
sepal_ui/aoi/aoi_view.py |
Update admin-name lookup to pygaul.Names for GAUL 2024 compatibility. |
tests/test_aoi/test_AoiView.py |
Adjust GAUL test expectations (Holy See code, first item code). |
tests/test_aoi/test_AoiModel.py |
Update admin code, GAUL asset path, column names/types, and fixture wording. |
tests/test_aoi/test_AoiModel/test_get_columns.yml |
Refresh expected GAUL 2024 column snapshot. |
tests/test_aoi/test_AoiModel/test_total_bounds.yml |
Refresh expected bounds snapshot. |
pyproject.toml |
Bump localtileserver, bump pygaul, remove rio-tiler<7 pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add isinstance check for iso to prevent AttributeError when iso3_code is None - Update AdminField docstring from GAUL 2015 to GAUL 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 79.79% 79.81% +0.01%
==========================================
Files 55 55
Lines 5518 5523 +5
==========================================
+ Hits 4403 4408 +5
Misses 1115 1115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update pygaul>=0.4.2 for FAO GAUL 2024 dataset support
Update localtileserver>=0.10.1 and remove rio-tiler<7 pin