-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add useful ofParameter constructor #6194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hiroMTB
wants to merge
25
commits into
openframeworks:patch-release
from
hiroMTB:feature-ofParameter-useful-constructor
Closed
Add useful ofParameter constructor #6194
hiroMTB
wants to merge
25
commits into
openframeworks:patch-release
from
hiroMTB:feature-ofParameter-useful-constructor
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for patch-release to master
Fix to the Xcode template making PG work with certain addons.
apply a fix to remove ssl libraries installed in windows and reinstall them through pacman. This was making tests fail to run cause of missing dlls
Fixes openframeworks#6133 The scrolling was still being handled when the gui was not being drawn both in ofxSlider and ofxInputField. Tested using the code provided in the mentioned issue. Also, there is some redundant code in ofxSlider.cpp and ofxInputField.cpp. Both have a function called toRange(...) which is identical in both. When the scroll callback is called this function is called. Can't we move this function to the ofxBaseGui for instance? Also, the code used in the scroll callback in both ofxSlider and ofxInputField is quite similar, maybe moving this to ofxBaseGui might be better too.
ofSoundBuffer::checkSizeAndChannelsConsistency is crashing when calling ofSoundBuffer::getChannel with channels = 1
This reverts commit 19e083d.
…rks into patch-release
…ble via initializer list
…erializable via initializer list
Contributor
Author
|
This PR is closed because of wrong target branch, please refer to this one instead #6195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are able to initialize ofParameter like below in ofApp.h.
The first parameter (e.g. "FPS") is the name of parameter then initial value, min and max.
This is very useful because we can write in header file and reduce code in ofApp.cpp file.
I'm using this often in my project since I found this syntax in Entropy project(for example here),
It would be nicer if we could initialize "serializable" variable as well in same manner. With this PR we can write this way and reduce .setSerializable(false) in ofApp.cpp to avoid saving parameter to xml (or json).
*Same to ofReadOnlyParameter