ofDirectory::listDir performance improvement#7399
Closed
dimitre wants to merge 7 commits intoopenframeworks:masterfrom
Closed
ofDirectory::listDir performance improvement#7399dimitre wants to merge 7 commits intoopenframeworks:masterfrom
dimitre wants to merge 7 commits intoopenframeworks:masterfrom
Conversation
Member
|
Adding this issue for reference: #6129 |
Member
|
@dimitre going to do a PR just for the sorting speed for #6129 ListDir is still quite slow and I think a PR which doesn't break the api would be good. EDIT: a big issue is that ofDirectory::files is public, so there isn't really a way to change the type to of::filesystem::path without breaking things for people. I think maybe let's close this PR for now and revisit after 0.12.0. |
Member
Author
|
Nice. I think it is possible to update ofDirectory not to open file immediatly. this would speed up everything. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still a draft. other things to do
as it breaks api, better to implement in a major version change. 0.12.0 ?
closes #6129