Skip to content

[wip] ofVideoPlayer string and path test #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[wip] ofVideoPlayer string and path test #8142

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84c9186
remove ambiguity between load(string) and load(fs::path) in videoplayer
dimitre Oct 11, 2024
2692b28
loadAsync
dimitre Oct 11, 2024
b1326b4
cleanup
dimitre Oct 11, 2024
faaf896
pg submodule
dimitre Oct 11, 2024
4175749
fix return in void function
dimitre Oct 11, 2024
f57ec48
merge master
dimitre Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/projectGenerator
Open in desktop
Submodule projectGenerator updated 10 files
+1 −1 .github/workflows/build-linux.yml
+1 −1 .github/workflows/build-macos.yml
+3 −2 commandLine/src/addons/ofAddon.cpp
+2 −1 commandLine/src/addons/ofAddon.h
+4 −4 commandLine/src/defines.h
+88 −91 commandLine/src/main.cpp
+76 −14 commandLine/src/projects/baseProject.cpp
+2 −43 commandLine/src/projects/baseProject.h
+1 −0 commandLine/src/projects/visualStudioProject.cpp
+157 −121 commandLine/src/projects/xcodeProject.cpp
2 changes: 1 addition & 1 deletion libs/openFrameworks/utils/ofConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

// version: ------------------------
#define OF_VERSION_MAJOR 0
#define OF_VERSION_MINOR 12
#define OF_VERSION_MINOR 13
#define OF_VERSION_PATCH 0
#define OF_VERSION_PRE_RELEASE "master"

Expand Down
4 changes: 2 additions & 2 deletions libs/openFrameworks/video/ofAVFoundationPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class ofAVFoundationPlayer : public ofBaseVideoPlayer {
ofAVFoundationPlayer();
~ofAVFoundationPlayer();

bool load(const of::filesystem::path & fileName) override;
void loadAsync(const of::filesystem::path & fileName) override;
bool load(const of::filesystem::path & fileName);
void loadAsync(const of::filesystem::path & fileName);
void close();
void update();

Expand Down
8 changes: 7 additions & 1 deletion libs/openFrameworks/video/ofVideoBaseTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,10 @@ class ofBaseVideoPlayer: virtual public ofBaseVideo{
/// \sa loadAsync()

virtual bool load(const of::filesystem::path & fileName) = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might need to be not pure virtual as inherited classes from older addons won't have this implemented

virtual bool load(std::string name) {
return load(of::filesystem::path(name));
}

/// \brief Asynchronously load a video resource by name.
///
/// The list of supported video types and sources (e.g. rtsp:// sources) is
Expand All @@ -220,7 +224,9 @@ class ofBaseVideoPlayer: virtual public ofBaseVideo{
/// \param name The name of the video resource to load.
/// \sa isLoaded()
virtual void loadAsync(const of::filesystem::path & fileName);

virtual bool loadAsync(std::string name) {
loadAsync(of::filesystem::path(name));
}
/// \brief Play the video from the current playhead position.
///
/// \sa getPosition()
Expand Down
1 change: 1 addition & 0 deletions libs/openFrameworks/video/ofVideoPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class ofVideoPlayer : public ofBaseVideoDraws {

bool load(const of::filesystem::path & fileName);
void loadAsync(const of::filesystem::path & fileName);

[[deprecated("Use load")]]
bool loadMovie(const of::filesystem::path & fileName);

Expand Down
Loading