Skip to content

more .h includes simplification #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

more .h includes simplification #8187

wants to merge 21 commits into from

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Nov 12, 2024 •
edited
Loading

This PR removes some includes from ofConstants.h and include by demand where needed.
includes are:

#include <stdint.h>
#include <cstdio>
#include <cstdlib>
#include <string>
#include <cstring>
#include <iostream>
#include <vector>
#include <memory>
#include <functional>

We can add them to ofMain.h to assure they are still added on projects

Linux action runner is failing because of libgconf-2-4

@dimitre dimitre marked this pull request as ready for review November 13, 2024 01:29
@dimitre dimitre requested a review from ofTheo November 13, 2024 01:33
@dimitre
Copy link
Member Author

dimitre commented Nov 13, 2024

good to go. should we re-add includes in ofMain.h to keep all of them available ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofTheo ofTheo Awaiting requested review from ofTheo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dimitre