-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[test] ofTexture more straightforward way to see if it support GL_RGB16F #8212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
db16346
ofTexture more straightforward way to see if it support GL_RGB16F
dimitre f29fa7f
ofAppEGLWindow fixes
dimitre 815e333
more
dimitre c0264ad
more
dimitre 3ed7fa5
more
dimitre 5c5c3a7
more
dimitre d241cf8
more changes
dimitre c76815b
egl includes to .h
dimitre d768946
types conflict
dimitre 0768624
comment out some rpi runners to see if aarch64 completes
dimitre c3d3958
ok
dimitre 1ac3f14
ok
dimitre caebb40
Merge branch 'openframeworks:master' into tex
dimitre 7b60823
actions back to master
dimitre 07ebc3b
Merge branch 'openframeworks:master' into tex
dimitre c7629ed
updates test
dimitre 541aa1d
updates test
dimitre 7f4b61c
update armv7 copying armv6
dimitre 3d3ac7e
update armv7 copying armv6
dimitre c2b203f
fix ofSerial for windows?
dimitre e2d3f62
fix ofSerial for windows?
dimitre 6b9a8b1
fix ofSerial for windows?
dimitre 804f568
fix ofSerial for windows?
dimitre 3ee8489
revert ofMainLoop (remove GLFW)
dimitre 5cdd4ad
Merge branch 'openframeworks:master' into tex
dimitre 8703720
up submodule
dimitre 3b3ec81
revert ofSerial.h / .cpp
dimitre 6204559
revert unrelated changes
dimitre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule apothecary
updated
20 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this would maybe be a safer change as it keeps the original logic, but also checks for the define
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main idea was depart from ofGLESVersionFromGL which is very imprecise.
if you read the function it tries to parse from a string (that greatly varies from platform, video card) and I am suspecting this function returns both false positives and negatives.
a more deterministic way of define would be get this info from glGetString(GL_SHADING_LANGUAGE_VERSION);
but the simpler way would be just checking the presence of the define. if it exists it can be set.
OF uses this approach a lot in ofCubeMap
cc: @NickHardeman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - I think I was just imagining possible regressions where it might now default to GL_RGB16F instead of GL_RGB - one is a floating point texture and the other is unsigned char.
So that could mean some shaders might behave a little differently - curious if that would be very noticeable or not really an issue.
I think in general bug fixes should correct breaking bugs or existing issues without changing behavior, hence my caution.