Skip to content

Conversation

@NickHardeman
Copy link
Contributor

Fixes load times mentioned in #8267 by caching the bone list instead of searching through all the meshes and all the bones for every isBone() function call.

@dimitre
Copy link
Member

dimitre commented Feb 27, 2025

Lets merge this one

@NickHardeman
Copy link
Contributor Author

This fix greatly reduces scene parsing by limiting recursion, though it's not really a bug, it's a vast improvement for loading large, complex scenes. Would be nice to get in for v0.12.1 :) What do you think @ofTheo

@ofTheo ofTheo merged commit 039b1a8 into openframeworks:master Feb 28, 2025
15 checks passed
@ofTheo
Copy link
Member

ofTheo commented Feb 28, 2025

Was the issue in #8267 also related to textures or was this the main issue?

@NickHardeman
Copy link
Contributor Author

There may still be a texture issue, but this was the main slow down ( 30 seconds ), now resulting in load times comparable to the older ofxAssimpModelLoader ~13 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants