Skip to content

Conversation

@danoli3
Copy link
Member

@danoli3 danoli3 commented Mar 20, 2025

ofURLFileLoader

  • fix missing POST (broken by else statement)
  • Fix issue for Async threads throwing exceptions (and randomly failing to complete directive)

cURL

  • minor update api of deprecated PUT changed to UPLOAD
C/C++: /home/runner/work/openFrameworks/openFrameworks/libs/openFrameworks/utils/ofURLFileLoader.cpp:341:32: 
warning: 'CURLOPT_PUT' is deprecated: since 7.12.1. Use CURLOPT_UPLOAD [-Wdeprecated-declarations]
C/C++:   341 |                 curl_easy_setopt(curl.get(), CURLOPT_PUT, 0);
C/C++:       |                                              ^
C/C++: /home/runner/work/openFrameworks/openFrameworks/libs/openFrameworksCompiled/project/android/openframeworksAndroid/../../../../../libs/curl/include/curl/curl.h:1294:3: note:
 'CURLOPT_PUT' has been explicitly marked deprecated here
C/C++:  1294 |   CURLOPTDEPRECATED(CURLOPT_PUT, CURLOPTTYPE_LONG, 54,
C/C++:       |   ^
C/C++: /home/runner/work/openFrameworks/openFrameworks/libs/openFrameworksCompiled/project/android/openframeworksAndroid/../../../../../libs/curl/include/curl/curl.h:1090:43: note: expanded from macro 'CURLOPTDEPRECATED'
C/C++:  1090 | #define CURLOPTDEPRECATED(na,t,nu,v,m) na CURL_DEPRECATED(v,m) = t + nu
C/C++:       |                                           ^

OpenSSL

  • Update createSSL cert from 1.1 style deprecated to 3 EVP_PKEY_CTX_new_from_name

@danoli3
Copy link
Member Author

danoli3 commented Mar 20, 2025

Chasing a thread / crash bug for these changes ^
image
Microsoft C++ exception: std::bad_function_call at memory location 0x000000AC985BEE40.

@danoli3 danoli3 marked this pull request as draft March 20, 2025 17:01
@danoli3 danoli3 marked this pull request as ready for review March 28, 2025 02:55
@danoli3
Copy link
Member Author

danoli3 commented Mar 28, 2025

Okay this is tested and fixes issues with cURL / openSSL and ofURLFileLoader issues for ASYNC downloads and changes to API

@danoli3 danoli3 added the bug label Mar 28, 2025
@danoli3 danoli3 added this to the 0.12.1 milestone Mar 28, 2025
@danoli3 danoli3 merged commit 3440022 into openframeworks:master Mar 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant